Skip to content

Conversation

simbig
Copy link
Contributor

@simbig simbig commented Mar 31, 2022

No description provided.

@simbig simbig requested a review from mic-web April 4, 2022 07:24
@simbig simbig requested a review from mic-web April 7, 2022 09:27
@spawnia
Copy link
Member

spawnia commented Apr 7, 2022

This pull request should be squashed, and the new commit message should detail the breaking changes using the proper format to ensure it results in a major version bump.

@simbig
Copy link
Contributor Author

simbig commented Apr 7, 2022

This pull request should be squashed, and the new commit message should detail the breaking changes using the proper format to ensure it results in a major version bump.

Good hint!
With the exception of the Plate component, I've kept the API compatible with the current version.

I wonder if it's better to add more cleanups and delete previously used code and make a one breaking change in the next release, or if it's worth staying downward compatible, not making any breaking changes for now and just adding deprecation docs and warnings like the following.

export function Plate(props: PlateProps) {
  ....

  if (!props.coordinateSystem) {
    console.warn('Deprecated usage of Plate-component. Provide coordinateSystem!')
  }

  const coordinateSystem: CoordinateSystem = props.coordinateSystem ?? new CoordinateSystem96Well()
.....

@spawnia
Copy link
Member

spawnia commented Apr 7, 2022

Move fast and break things 😉 (and upgrade our applications proactively while you still know exactly what to do)

Simon Bigelmayr and others added 4 commits April 22, 2024 13:48
…plate_component

# Conflicts:
#	src/Plate/index.stories.tsx
#	src/Plate/index.tsx
#	src/Plate/utils.test.tsx
#	src/Plate/utils.ts
@spawnia
Copy link
Member

spawnia commented Sep 9, 2024

@simbig This pull request should be superseded by #281.

@simbig simbig closed this Oct 10, 2024
@simbig simbig deleted the add_coordinate_system_logic_to_plate_component branch October 10, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants