-
Notifications
You must be signed in to change notification settings - Fork 2
feat: global forms provider #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
ca725e2
feat: global forms provider
mic-web d344d7e
fix: install react-test-renderer
mic-web 31770af
fix: use yarn 4
mic-web 049e6ba
fix: use act from @testing-library/react-hooks
mic-web 2c836f4
refactor: undo yarn changes as no package updates were done
mic-web bd42530
Merge remote-tracking branch 'origin/master' into global-forms-provider
mic-web 1c2414a
Merge remote-tracking branch 'origin/master' into global-forms-provider
mic-web c535628
refactor: rename FormInfoObjectOrString
mic-web 6725609
docs: submit
mic-web bf61ec5
refactor: render hook options fn
mic-web 88853c5
object.values
mic-web a1da92f
refactor: use object functions
mic-web f52edc7
refactor: make GlobalFormContext private
mic-web 8e2cf6f
fix: export
mic-web ac3e5b7
Update src/GlobalFormsProvider/GlobalFormsContext.ts
mic-web 0b80248
Update src/GlobalFormsProvider/GlobalFormsContext.ts
mic-web 26d3ab0
Update src/GlobalFormsProvider/GlobalFormsProvider.tsx
mic-web 80ff6d9
refactor: import maybe
mic-web File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,88 @@ | ||
import React, { useCallback, useContext, useMemo } from 'react'; | ||
|
||
export type FormInfo = { name: string; order: number }; | ||
type FormInfoObjectOrString = FormInfo | string; | ||
|
||
export type CallbackWithOrder = { | ||
callback: () => Promise<void>; | ||
order: number; | ||
}; | ||
|
||
export type GlobalFormsContextType = { | ||
isSubmitting: boolean; | ||
reset: () => void; | ||
setResetCallback: (form: FormInfo, callback: () => void) => void; | ||
setSubmitCallback: (form: FormInfo, callback: () => Promise<void>) => void; | ||
setSubmitting: (form: FormInfo, submitting: boolean) => void; | ||
setSubmitSuccessful: (form: FormInfo, submitSuccessful: boolean) => void; | ||
/** Returns true when all forms were submitted successfully. */ | ||
submit: (additionalCallback?: CallbackWithOrder) => Promise<boolean>; | ||
}; | ||
|
||
export const GlobalFormsContext = React.createContext<GlobalFormsContextType>({ | ||
isSubmitting: false, | ||
reset: () => {}, | ||
setResetCallback: () => {}, | ||
setSubmitCallback: () => {}, | ||
setSubmitting: () => {}, | ||
setSubmitSuccessful: () => {}, | ||
submit: () => Promise.resolve(false), | ||
}); | ||
|
||
export function useGlobalForms() { | ||
return useContext(GlobalFormsContext); | ||
} | ||
|
||
export function normalizeFormInfo(form: FormInfoObjectOrString): FormInfo { | ||
if (typeof form === 'string') { | ||
return { name: form, order: 0 }; | ||
} | ||
|
||
return form; | ||
} | ||
|
||
export function useGlobalForm(form: FormInfoObjectOrString) { | ||
const formInfo = useMemo(() => normalizeFormInfo(form), [form]); | ||
|
||
const { | ||
setResetCallback, | ||
setSubmitCallback, | ||
setSubmitting, | ||
setSubmitSuccessful, | ||
} = useContext(GlobalFormsContext); | ||
|
||
const setResetCallbackWrapped = useCallback( | ||
(callback: () => void) => { | ||
setResetCallback(formInfo, callback); | ||
}, | ||
[formInfo, setResetCallback], | ||
); | ||
|
||
const setSubmitCallbackWrapped = useCallback( | ||
(callback: () => Promise<void>) => { | ||
setSubmitCallback(formInfo, callback); | ||
}, | ||
[formInfo, setSubmitCallback], | ||
); | ||
|
||
const setSubmittingWrapped = useCallback( | ||
(submitting: boolean) => { | ||
setSubmitting(formInfo, submitting); | ||
}, | ||
[formInfo, setSubmitting], | ||
); | ||
|
||
const setSubmitSuccessfulWrapped = useCallback( | ||
(submitSuccessful: boolean) => { | ||
setSubmitSuccessful(formInfo, submitSuccessful); | ||
}, | ||
[formInfo, setSubmitSuccessful], | ||
); | ||
|
||
return { | ||
setResetCallback: setResetCallbackWrapped, | ||
setSubmitCallback: setSubmitCallbackWrapped, | ||
setSubmitSuccessful: setSubmitSuccessfulWrapped, | ||
setSubmitting: setSubmittingWrapped, | ||
}; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,179 @@ | ||
import { | ||
act, | ||
renderHook, | ||
RenderHookOptions, | ||
} from '@testing-library/react-hooks'; | ||
import React, { PropsWithChildren } from 'react'; | ||
|
||
import { useGlobalForms, useGlobalForm } from './GlobalFormsContext'; | ||
import { GlobalFormsProvider } from './GlobalFormsProvider'; | ||
|
||
function createRenderHookOptions(): RenderHookOptions< | ||
PropsWithChildren<unknown> | ||
> { | ||
return { | ||
wrapper: function Wrapper({ children }: PropsWithChildren<unknown>) { | ||
return <GlobalFormsProvider>{children}</GlobalFormsProvider>; | ||
}, | ||
}; | ||
} | ||
|
||
describe('GlobalFormsProvider', () => { | ||
it('finds one submitting form', () => { | ||
const { result } = renderHook(() => { | ||
const { isSubmitting } = useGlobalForms(); | ||
const { setSubmitting: setSubmitting1 } = useGlobalForm('form1'); | ||
const { setSubmitting: setSubmitting2 } = useGlobalForm('form2'); | ||
|
||
return { isSubmitting, setSubmitting1, setSubmitting2 }; | ||
}, createRenderHookOptions()); | ||
expect(result.error).toBeFalsy(); | ||
expect(result.current.isSubmitting).toBeFalsy(); | ||
|
||
act(() => result.current.setSubmitting1(true)); | ||
act(() => result.current.setSubmitting2(false)); | ||
expect(result.current.isSubmitting).toBeTruthy(); | ||
}); | ||
|
||
it('overrides submitting value', () => { | ||
const { result } = renderHook(() => { | ||
const { isSubmitting } = useGlobalForms(); | ||
const { setSubmitting } = useGlobalForm('form'); | ||
|
||
return { isSubmitting, setSubmitting }; | ||
}, createRenderHookOptions()); | ||
expect(result.current.isSubmitting).toBeFalsy(); | ||
|
||
act(() => result.current.setSubmitting(true)); | ||
expect(result.current.isSubmitting).toBeTruthy(); | ||
|
||
act(() => result.current.setSubmitting(false)); | ||
expect(result.current.isSubmitting).toBeFalsy(); | ||
}); | ||
|
||
it('calls all reset callbacks', () => { | ||
const { result } = renderHook(() => { | ||
const { reset } = useGlobalForms(); | ||
const { setResetCallback: setResetCallback1 } = useGlobalForm('form1'); | ||
const { setResetCallback: setResetCallback2 } = useGlobalForm('form2'); | ||
|
||
return { reset, setResetCallback1, setResetCallback2 }; | ||
}, createRenderHookOptions()); | ||
result.current.reset(); | ||
|
||
const reset1 = jest.fn(); | ||
act(() => result.current.setResetCallback1(reset1)); | ||
|
||
const reset2 = jest.fn(); | ||
act(() => result.current.setResetCallback2(reset2)); | ||
|
||
result.current.reset(); | ||
expect(reset1).toHaveBeenCalledTimes(1); | ||
expect(reset2).toHaveBeenCalledTimes(1); | ||
|
||
act(() => result.current.setResetCallback1(jest.fn())); | ||
result.current.reset(); | ||
expect(reset1).toHaveBeenCalledTimes(1); | ||
expect(reset2).toHaveBeenCalledTimes(2); | ||
}); | ||
|
||
it('overrides reset callback', () => { | ||
const { result } = renderHook(() => { | ||
const { reset } = useGlobalForms(); | ||
const { setResetCallback } = useGlobalForm('form'); | ||
|
||
return { reset, setResetCallback }; | ||
}, createRenderHookOptions()); | ||
const resetOld = jest.fn(); | ||
act(() => result.current.setResetCallback(resetOld)); | ||
result.current.reset(); | ||
expect(resetOld).toHaveBeenCalledTimes(1); | ||
|
||
const resetNew = jest.fn(); | ||
act(() => result.current.setResetCallback(resetNew)); | ||
result.current.reset(); | ||
expect(resetOld).toHaveBeenCalledTimes(1); | ||
expect(resetNew).toHaveBeenCalledTimes(1); | ||
}); | ||
|
||
it('calls all submit callbacks', async () => { | ||
const { result } = renderHook(() => { | ||
const { submit } = useGlobalForms(); | ||
const { setSubmitCallback: setSubmitCallback1 } = useGlobalForm('form1'); | ||
const { setSubmitCallback: setSubmitCallback2 } = useGlobalForm('form2'); | ||
|
||
return { submit, setSubmitCallback1, setSubmitCallback2 }; | ||
}, createRenderHookOptions()); | ||
await expect(result.current.submit()).resolves.toBeTruthy(); | ||
|
||
const submit1 = jest.fn(() => Promise.resolve()); | ||
act(() => result.current.setSubmitCallback1(submit1)); | ||
|
||
const submit2 = jest.fn(() => Promise.resolve()); | ||
act(() => result.current.setSubmitCallback2(submit2)); | ||
|
||
await expect(result.current.submit()).resolves.toBeFalsy(); | ||
expect(submit1).toHaveBeenCalledTimes(1); | ||
expect(submit2).toHaveBeenCalledTimes(1); | ||
}); | ||
|
||
it('overrides submit callback', async () => { | ||
const { result } = renderHook(() => { | ||
const { submit } = useGlobalForms(); | ||
const { setSubmitCallback } = useGlobalForm('form'); | ||
|
||
return { submit, setSubmitCallback }; | ||
}, createRenderHookOptions()); | ||
|
||
const submitOld = jest.fn(() => Promise.resolve()); | ||
act(() => result.current.setSubmitCallback(submitOld)); | ||
|
||
await expect(result.current.submit()).resolves.toBeFalsy(); | ||
expect(submitOld).toHaveBeenCalledTimes(1); | ||
|
||
const submitNew = jest.fn(() => Promise.resolve()); | ||
act(() => result.current.setSubmitCallback(submitNew)); | ||
|
||
await expect(result.current.submit()).resolves.toBeFalsy(); | ||
expect(submitOld).toHaveBeenCalledTimes(1); | ||
expect(submitNew).toHaveBeenCalledTimes(1); | ||
}); | ||
|
||
it('maintains submit order', async () => { | ||
const { result } = renderHook(() => { | ||
const { submit } = useGlobalForms(); | ||
const { setSubmitCallback: setSubmitCallbackError } = useGlobalForm({ | ||
name: 'form-error', | ||
order: 2, | ||
}); | ||
const { setSubmitCallback: setSubmitCallbackFirst } = useGlobalForm({ | ||
name: 'form-first', | ||
order: 1, | ||
}); | ||
const { setSubmitCallback: setSubmitCallbackLast } = useGlobalForm({ | ||
name: 'form-last', | ||
order: 3, | ||
}); | ||
|
||
return { | ||
submit, | ||
setSubmitCallbackError, | ||
setSubmitCallbackFirst, | ||
setSubmitCallbackLast, | ||
}; | ||
}, createRenderHookOptions()); | ||
const submitError = jest.fn(() => Promise.reject()); | ||
act(() => result.current.setSubmitCallbackError(submitError)); | ||
|
||
const submitFirst = jest.fn(() => Promise.resolve()); | ||
act(() => result.current.setSubmitCallbackFirst(submitFirst)); | ||
|
||
const submitLast = jest.fn(() => Promise.resolve()); | ||
act(() => result.current.setSubmitCallbackLast(submitLast)); | ||
|
||
await expect(result.current.submit()).rejects.toBeFalsy(); | ||
expect(submitFirst).toHaveBeenCalledTimes(1); | ||
expect(submitError).toHaveBeenCalledTimes(1); | ||
expect(submitLast).toHaveBeenCalledTimes(0); | ||
mic-web marked this conversation as resolved.
Show resolved
Hide resolved
|
||
}); | ||
}); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.