Skip to content

Add DANRA tutorial notebook with pytest-nbmake#705

Closed
GiGiKoneti wants to merge 1 commit into
mllam:mainfrom
GiGiKoneti:takeover/danra-notebook-ci
Closed

Add DANRA tutorial notebook with pytest-nbmake#705
GiGiKoneti wants to merge 1 commit into
mllam:mainfrom
GiGiKoneti:takeover/danra-notebook-ci

Conversation

@GiGiKoneti

Copy link
Copy Markdown
Contributor

Describe your changes

This PR takes over the work of PR #577 and Issue #69 to add the hello_world_danra.ipynb tutorial notebook.
It resolves all remaining review comments from @sadamov:

  1. Cell 17 (graph visualization): Replaces the oversized interactive plotly output (which caused the notebook to hang) with a lightweight, filtered display inline and writes the full interactive graph to graph_viz.html.
  2. Cell 17 (load_graph updates): Updated the python code in the cell to pass the required mesh_node_features_scaling parameter (matching the new graph format specification).
  3. Changelog Consolidation: Consolidated all PR 577 changelog entries into a single entry under the ## [unreleased] block, cleaning up duplicate headers in the frozen v0.6.0 release.

Issue Link

closes #69
refs #577

Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📖 Documentation (Addition or improvements to documentation)

Checklist before requesting a review

  • My branch is up-to-date with the target branch - if not update your fork with the changes from the target branch (use pull with --rebase option if possible).
  • I have performed a self-review of my code
  • For any new/modified functions/classes I have added docstrings that clearly describe its purpose, expected inputs and returned values
  • I have placed in-line comments to clarify the intent of any hard-to-understand passages of my code
  • I have updated the README to cover introduced code changes (no README changes needed for this onboarding notebook update)
  • I have added tests that prove my fix is effective or that my feature works
  • I have given the PR a name that clearly describes the change, written in imperative form.
  • I have requested a reviewer and an assignee (assignee is responsible for merging). This applies only if you have write access to the repo, otherwise feel free to tag a maintainer to add a reviewer and assignee.

Checklist for reviewers

  • the code is readable
  • the code is well tested
  • the code is documented (including return types and parameters)
  • the code is easy to maintain

Author checklist after completed review

  • I have added a line to the CHANGELOG describing this change, in a section reflecting type of change:
    • added: - Add hello_world_danra.ipynb... under ## [unreleased]

@sadamov

sadamov commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

@GiGiKoneti my bad, I thought there was much more to do, but actually there were only few remaining issues because of recent main mergers. Closing again...

@sadamov sadamov closed this Jul 15, 2026
@GiGiKoneti
GiGiKoneti deleted the takeover/danra-notebook-ci branch July 15, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add DANRA tutorial notebook with pytest-nbmake

2 participants