test: make CompatibleDtypeFeatureGroup test a distinct dtype path - #1090
Open
RawNuke wants to merge 1 commit into
Open
test: make CompatibleDtypeFeatureGroup test a distinct dtype path#1090RawNuke wants to merge 1 commit into
RawNuke wants to merge 1 commit into
Conversation
Collaborator
|
@RawNuke Please rebase this PR |
…peFeatureGroup Signed-off-by: RawNuke <67506722+RawNuke@users.noreply.github.com>
RawNuke
force-pushed
the
fix/1085/compatible-dtype-distinct-test
branch
from
August 7, 2026 16:01
2a51b47 to
c2a7153
Compare
Author
|
Rebased onto main. The test file had been refactored since I opened this, so rather than a messy merge I re-applied the change as a single additive test, test_compatible_dtype_passes_validation, on top of current main. It uses the existing CompatibleDtypeFeatureGroup class. Ready for CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #1085
CompatibleDtypeFeatureGroup was byte-identical to ForceFinalOnFinalEngine, both testing a string filter on a string column. This change replaces the string column with an integer rank column and uses an integer equal filter, making it test a genuinely distinct compatible-dtype scenario (int-vs-int instead of string-vs-string).
Changes
CompatibleDtypeFeatureGroup: changed fromstatus(string) column torank(int64) columntest_compatible_dtype_passes_validation: changed fromstatus == activefilter torank == 1integer equal filter[10, 30](rows with rank=1, matching ForceFinalOnFinalEngine's pair pattern)Verification
tests/test_core/test_filter/test_feature_group_final_filters.pypass