allow subscribe to multiple channels at once

[kwojtaszek]

No description provided.

[mloughran]

Allowing subscribing and unsubscribing to multiple channels seems reasonable since it would then match the design of the redis api (which is the general intent). However I see you've redefined the subscribe method without removing the old implementation, and the new implementation is not api compatible. Thoughts welcome.

Also, psubscribe and punsubscribe should be changed to match if one was to make changes.

Is it worth it?

[kwojtaszek]

@mloughran I didn't want to brake api for subscribing and unsubscribing, that's why add one method that allows user to pass multiple channels to subscribe. Do you think that dropping custom proc is worth breaking the subscription api?

You're right, psubscribe and punsubscribe should be changed to match that.

[sponomarev]

👍