Initial Implementation of LV2 module #983

joinlaw · 2024-05-11T19:16:04Z

Can be tested with melt eg:

$ melt ~/path/to/audio/file.wav -attach "lv2.http<//kxstudio.sf.net/carla/plugins/audiogain_s" 5=0.3 -consumer avformat:processed.mp3 acodec=libmp3lame

(:) in http://kxstudio.sf.net/carla/plugins/audiogain_s replaced with (<) because melt and/or mlt doesn't accept (:) in plugin name and also uri should be prefiexed with "lv2."

currently only this extensions are supported:
http://lv2plug.in/ns/ext/buf-size#boundedBlockLength
http://lv2plug.in/ns/ext/urid#map
http://lv2plug.in/ns/ext/urid#unmap
http://lv2plug.in/ns/ext/options#options

https://lv2plug.in/pages/host-compatibility.html

ddennedy

The approach of copying the jackrack module and modifying it is not acceptable. That brings in a lot of baggage. jackrack code base was chosen at a time when I needed to support a rack XML file made with its GUI tool for a customer. This was a time when there were only some toy GUI tools for MLT. As a bonus it added support for JACK. I later modified it to support a single named LADSPA plugin for Kdenlive and friends. This ought to be a cleaner implementation without all of that baggage. I guess you can get there by continuing to modify, but I am not in a situation where I want to go through many PR reviews to get there. Alternatively, can the existing jackrack module be extended to support LV2?

src/modules/lv2/factory.c

src/modules/lv2/filter_lv2.c

src/modules/lv2/filter_lv2.yml

src/modules/lv2/producer_lv2.yml

joinlaw · 2024-05-13T22:38:32Z

The approach of copying the jackrack module and modifying it is not acceptable. That brings in a lot of baggage. jackrack code base was chosen at a time when I needed to support a rack XML file made with its GUI tool for a customer. This was a time when there were only some toy GUI tools for MLT. As a bonus it added support for JACK. I later modified it to support a single named LADSPA plugin for Kdenlive and friends. This ought to be a cleaner implementation without all of that baggage. I guess you can get there by continuing to modify, but I am not in a situation where I want to go through many PR reviews to get there. Alternatively, can the existing jackrack module be extended to support LV2?

At first I tried to extend the jackrack module and even put both LADSPA and LV2 plugins in the same plugin manager but I fail to get working code for months until I tried copying and I get here.

Actually I have to think about the approach and take time to be more familiar with filter design in mlt. The problem is it was hard for me to use same structure of plugin/process/manager so I have to heavily alter it and only lock_free_fifo.c, lock_free_fifo.h files copied without modification.

joinlaw · 2024-05-17T19:56:04Z

with this commit aba53e9 now parameters metadata is more accurate and not causing issues and be readonly

And still I don't get dropdown options (enumerations) to work.

I am investigating ways to integrate this module in jackrack.

joinlaw · 2024-05-24T13:26:34Z

By now this feature is reimplemented as part of jackrack module and the old implementation moved to lv2-module-old-way https://github.com/joinlaw/mlt/tree/lv2-module-old-way branch.

@ddennedy

src/modules/jackrack/factory.c

src/modules/jackrack/filter_lv2.c

…at lv2 feature in jackrack module

…s in filter_lv2.yml

joinlaw · 2024-06-28T15:16:47Z

With commit 1de2a58 enumeration is supported and also I created MR in kdenlive project https://invent.kde.org/multimedia/kdenlive/-/merge_requests/520 to support it in the generic UI. In the case of Shotcut from what I see that shotcut does not generate generic effect UI there should be a manually created qt UI file and I don't look into other projects using mlt.

joinlaw · 2024-06-28T15:31:18Z

src/modules/jackrack/lv2_plugin.c

+  char *lv2context_can_ui = mlt_environment ("lv2context_can_ui");
+  if (lv2context_can_ui != NULL)
+    {
+      /* Video editors and other hosts that support custom GUI should use mlt_environment_set ("lv2context_can_ui", "1")
+	 to inform mlt lv2 plugin manager and set UI features and extensions if not set.
+       */
+      if (lv2context_can_ui[0] == '1')
+	{
+	  //WIP: if support UI
+	}
+    }


For hosts (ie. Video Editors) that want to support LV2 Custom GUIs they should set the mlt environment variable "lv2context_can_ui" to "1" and the the lv2 plugin instance will be instantiated with LV2 UI features and extensions and then they can get "global_lv2_world" handle of LilvWorld* and and retrieve the UI URI and handles and create ui support with suil library (http://drobilla.net/software/suil.html).

This is the plan for supporting Custom GUIs.

ddennedy · 2024-06-28T21:46:21Z

Do not force push to a PR that has a lot of changes and already had some review. When you force push I need to start over the review because I can not see what you changed from I left off. And when there is a lot of code, it makes the reviewer more reluctant to start over.

CMakeLists.txt

ddennedy · 2024-06-28T22:30:57Z

src/modules/jackrack/CMakeLists.txt

+
+  if(USE_LV2 AND TARGET PkgConfig::lilv)
+    target_link_libraries(mltjackrack PRIVATE PkgConfig::lilv)
+    target_sources(mltjackrack PRIVATE filter_lv2.c producer_lv2.c lv2_context.c lv2_plugin.c lv2_process.c lv2_plugin_settings.c)


Please add the new header files to this as well as my IDE uses this to show the project files. You can see all of our CMakeLists.txt do that including other target_sources in the same file.

ddennedy · 2024-06-28T22:48:49Z

Build target clang-format-check fails with many errors. I noticed problems immediately when I start editing files, and git diff showed many unrelated changes because my IDE is setup to follow our clang-format rules and reformats some of the code. One of the biggest issues is using tab characters for indent. clang-format should be following our include .clang-format config file.

ddennedy · 2024-06-28T23:15:22Z

Not wanting to be a total downer, I did run it (with my change to use ^), and it is working including things like melt -query and serializing to XML with melt -consumer xml my.mp4 -attach lv2.http^//calf.sourceforge.net/plugins/Crusher 20=100

...
    <filter id="filter0">
      <property name="mlt_service">lv2.http^//calf.sourceforge.net/plugins/Crusher</property>
      <property name="20">100</property>
    </filter>
...

I also ran the above for several frames through valgrind, and it did not complain about any memory problems in this new code. So, just these few things to tidy up, and it is ready!

…ead of <

ddennedy requested changes May 12, 2024

View reviewed changes

joinlaw force-pushed the lv2-module branch 2 times, most recently from 9646013 to 189bbf4 Compare May 24, 2024 13:20

ddennedy reviewed May 24, 2024

View reviewed changes

src/modules/jackrack/factory.c Outdated Show resolved Hide resolved

ddennedy requested changes May 24, 2024

View reviewed changes

src/modules/jackrack/filter_lv2.c Outdated Show resolved Hide resolved

src/modules/jackrack/filter_lv2.c Outdated Show resolved Hide resolved

joinlaw force-pushed the lv2-module branch from dcbacae to 34d5039 Compare May 25, 2024 21:50

joinlaw force-pushed the lv2-module branch from afbd9c0 to 1de2a58 Compare June 28, 2024 14:16

mr.fantastic added 5 commits June 28, 2024 17:19

Adding initial LV2 support for jackrack module

57beaea

renaming lv2_rack to lv2_context, updating copyright year, clang-form…

92725a5

…at lv2 feature in jackrack module

Removing the wrong reference to JACK Rack XML file resource parameter…

cfbf294

…s in filter_lv2.yml

Adding more static features to lv2 instance run

5534940

Adding support to enumeration parameter type in lv2 module

1de2a58

joinlaw commented Jun 28, 2024

View reviewed changes

ddennedy requested changes Jun 28, 2024

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

CMakeLists.txt Show resolved Hide resolved

ddennedy reviewed Jun 28, 2024

View reviewed changes

Removing unused lv2 code, refactor CMake files, replace : with ^ inst…

749ad75

…ead of <

ddennedy added this to the v7.26.0 milestone Jul 1, 2024

ddennedy merged commit 8c744a6 into mltframework:master Jul 1, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial Implementation of LV2 module #983

Initial Implementation of LV2 module #983

joinlaw commented May 11, 2024

ddennedy left a comment

joinlaw commented May 13, 2024

joinlaw commented May 17, 2024

joinlaw commented May 24, 2024 •

edited

Loading

joinlaw commented Jun 28, 2024

joinlaw Jun 28, 2024

ddennedy commented Jun 28, 2024

ddennedy Jun 28, 2024

ddennedy commented Jun 28, 2024

ddennedy commented Jun 28, 2024

Initial Implementation of LV2 module #983

Initial Implementation of LV2 module #983

Conversation

joinlaw commented May 11, 2024

ddennedy left a comment

Choose a reason for hiding this comment

joinlaw commented May 13, 2024

joinlaw commented May 17, 2024

joinlaw commented May 24, 2024 • edited Loading

joinlaw commented Jun 28, 2024

joinlaw Jun 28, 2024

Choose a reason for hiding this comment

ddennedy commented Jun 28, 2024

ddennedy Jun 28, 2024

Choose a reason for hiding this comment

ddennedy commented Jun 28, 2024

ddennedy commented Jun 28, 2024

joinlaw commented May 24, 2024 •

edited

Loading