-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Android parser for new Play Store format #1044
base: master
Are you sure you want to change the base?
Conversation
Updating AndroidAppsMetadata to parse newest Play Store format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've added some comments.
@@ -101,9 +101,9 @@ MetadataHelper::MetadataHelper(QString log_tag) | |||
, rx_meta_itemprops(QStringLiteral(R""(<meta itemprop="(.+?)" content="(.+?)")""), QRegularExpression::DotMatchesEverythingOption) | |||
, rx_background(QStringLiteral(R""(<meta property="og:image" content="(.+?)")"")) | |||
, rx_developer(QStringLiteral(R""(<a href="/store\/apps\/dev(eloper)?\?id=.+?" class=".*?">([^<]+)<\/a><\/span>)"")) | |||
, rx_category(QStringLiteral(R""(<a itemprop="genre".*?>([^<]+)<\/a>)"")) | |||
, rx_category(QStringLiteral(R""(href="\/store\/apps\/category\/([^"]+)" aria-label)"")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to me that the category href is uppercase; perhaps we could use the aria label instead? An example:
<a class="..." href="/store/apps/category/TOOLS" aria-label="Tools" jsname="...">
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good approach. What about this then:
, rx_category(QStringLiteral(R""(href="\/store\/apps\/category\/([^"]+)" aria-label)"")) | |
, rx_category(QStringLiteral(R""(href="\/store\/apps\/category\/[^"]+" aria-label="(.*?)")"")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this looks better.
Updating AndroidAppsMetadata to parse latestPlay Store format