Enable xml:base URI resolution for RSS feeds #224
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables xml:base resolution for HTML within RSS feeds. Note: - Relative URLs are even less common and more discouraged in RSS than they are in Atom. - Unlike Atom, RSS does not have a good way to indicate when an element contains HTML. This implementation attempts to parse the contents of many elements as HTML (this includes the contents of `description` as well as `title`, `copyright`, etc.). It would probably be safer to limit this to description only. - Tests only cover RSS 2 and are minimal. I would not merge this until it is tested against some real-world RSS and RDF feeds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi mmcdole -
For completion's sake, here is a PR that enables xml:base URI resolution for the RSS parser. As I mention in the commit message, I'm not recommending to merge (without more real-world testing), but I'll keep the branch around so if anybody ever requests the feature you can point them toward it.