Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mass update of all dependencies #171

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

lewismc
Copy link
Member

@lewismc lewismc commented Jul 17, 2020

Hi @carueda for a bit of fun I went ahead and mass updated each dependency in the package.json file. Of course this breaks quite a bit. Namely,

npm install
...
npm WARN deprecated [email protected]: gulp-util is deprecated - replace it, following the guidelines at https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5
npm WARN deprecated [email protected]: this package is now deprecated
npm WARN deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated [email protected]: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.

> [email protected] install /Users/lmcgibbn/Downloads/orr-portal/node_modules/fsevents
> node install.js

ERROR:root:code for hash md5 was not found.
Traceback (most recent call last):
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 147, in <module>
    globals()[__func_name] = __get_hash(__func_name)
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 97, in __get_builtin_constructor
    raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type md5
ERROR:root:code for hash sha1 was not found.
Traceback (most recent call last):
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 147, in <module>
    globals()[__func_name] = __get_hash(__func_name)
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 97, in __get_builtin_constructor
    raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type sha1
ERROR:root:code for hash sha224 was not found.
Traceback (most recent call last):
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 147, in <module>
    globals()[__func_name] = __get_hash(__func_name)
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 97, in __get_builtin_constructor
    raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type sha224
ERROR:root:code for hash sha256 was not found.
Traceback (most recent call last):
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 147, in <module>
    globals()[__func_name] = __get_hash(__func_name)
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 97, in __get_builtin_constructor
    raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type sha256
ERROR:root:code for hash sha384 was not found.
Traceback (most recent call last):
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 147, in <module>
    globals()[__func_name] = __get_hash(__func_name)
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 97, in __get_builtin_constructor
    raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type sha384
ERROR:root:code for hash sha512 was not found.
Traceback (most recent call last):
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 147, in <module>
    globals()[__func_name] = __get_hash(__func_name)
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 97, in __get_builtin_constructor
    raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type sha512
  SOLINK_MODULE(target) Release/.node
  CXX(target) Release/obj.target/fse/fsevents.o
In file included from ../fsevents.cc:6:
In file included from ../../nan/nan.h:55:
In file included from /Users/lmcgibbn/Library/Caches/node-gyp/14.4.0/include/node/uv.h:52:
In file included from /Users/lmcgibbn/Library/Caches/node-gyp/14.4.0/include/node/uv/errno.h:25:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/errno.h:32:15: fatal error: 'errno.h' file not found
#include_next <errno.h>
              ^~~~~~~~~
1 error generated.
make: *** [Release/obj.target/fse/fsevents.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:276:12)
gyp ERR! System Darwin 18.7.0
gyp ERR! command "/usr/local/Cellar/node/14.4.0/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/lmcgibbn/Downloads/orr-portal/node_modules/fsevents
gyp ERR! node -v v14.4.0
gyp ERR! node-gyp -v v5.1.0
gyp ERR! not ok

> [email protected] install /Users/lmcgibbn/Downloads/orr-portal/node_modules/phantomjs-prebuilt
> node install.js

PhantomJS not found on PATH
Download already available at /var/folders/3p/t0shq8j10q56q45ntm0skn00fv8362/T/phantomjs/phantomjs-2.1.1-macosx.zip
Verified checksum of previously downloaded file
Extracting zip contents
Removing /Users/lmcgibbn/Downloads/orr-portal/node_modules/phantomjs-prebuilt/lib/phantom
Copying extracted folder /var/folders/3p/t0shq8j10q56q45ntm0skn00fv8362/T/phantomjs/phantomjs-2.1.1-macosx.zip-extract-1595028008322/phantomjs-2.1.1-macosx -> /Users/lmcgibbn/Downloads/orr-portal/node_modules/phantomjs-prebuilt/lib/phantom
Writing location.js file
Done. Phantomjs binary available at /Users/lmcgibbn/Downloads/orr-portal/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs
npm notice created a lockfile as package-lock.json. You should commit this file.
added 806 packages from 1084 contributors and audited 810 packages in 17.197s

30 packages are looking for funding
  run `npm fund` for details

found 4 vulnerabilities (1 low, 2 high, 1 critical)
  run `npm audit fix` to fix them, or `npm audit` for details

It looks like the fatal error: 'errno.h' file not found is a local environment error on my part.

gulp install --dest=install
[16:29:15] Building version 3.9.6
[16:29:15] dest=install
[16:29:15] Install destination: install
[16:29:15] Using gulpfile ~/Downloads/orr-portal/gulpfile.js
[16:29:15] Starting 'install'...
[16:29:15] Starting 'check_dest'...
[16:29:15] Finished 'check_dest' after 641 μs
[16:29:15] Starting 'localConfig'...
[16:29:15] Starting 'baseStuff'...
[16:29:15] app task: EXCLUDING local.config.js
[16:29:15] Finished 'localConfig' after 8.27 ms
[16:29:15] Finished 'baseStuff' after 9.86 ms
[16:29:15] Starting 'vendor'...
[16:29:15] Finished 'vendor' after 4.11 ms
[16:29:15] Starting 'do_package'...
[16:29:15] Finished 'do_package' after 2.69 ms
[16:29:15] Starting 'config'...
[16:29:15] config: EXCLUDING local.config.js
[16:29:15] Finished 'config' after 1.81 ms
[16:29:15] Starting 'img'...
[16:29:15] Finished 'img' after 1.37 ms
[16:29:15] Starting 'vendor_other_fontawesome'...
[16:29:15] Starting 'vendor_other_bootstrap'...
[16:29:15] Finished 'vendor_other_fontawesome' after 1.25 ms
[16:29:15] Finished 'vendor_other_bootstrap' after 2.42 ms
[16:29:15] Starting 'app_min_js'...
[16:29:15] Finished 'app_min_js' after 11 ms
[16:29:15] Starting 'app_min_css'...
[16:29:15] Finished 'app_min_css' after 3.45 ms
[16:29:15] Starting 'do_install'...
[16:29:15] Finished 'do_install' after 1.33 ms
[16:29:15] Finished 'install' after 43 ms
events.js:292
      throw er; // Unhandled 'error' event
      ^

Error: File not found with singular glob: /Users/lmcgibbn/Downloads/orr-portal/node_modules/angular-ui-grid/ui-grid.woff (if this was purposeful, use `allowEmpty` option)
    at Glob.<anonymous> (/Users/lmcgibbn/Downloads/orr-portal/node_modules/glob-stream/readable.js:84:17)
    at Object.onceWrapper (events.js:422:26)
    at Glob.emit (events.js:315:20)
    at Glob.EventEmitter.emit (domain.js:485:12)
    at Glob._finish (/Users/lmcgibbn/Downloads/orr-portal/node_modules/glob/glob.js:197:8)
    at done (/Users/lmcgibbn/Downloads/orr-portal/node_modules/glob/glob.js:182:14)
    at Glob._processSimple2 (/Users/lmcgibbn/Downloads/orr-portal/node_modules/glob/glob.js:688:12)
    at /Users/lmcgibbn/Downloads/orr-portal/node_modules/glob/glob.js:676:10
    at Glob._stat2 (/Users/lmcgibbn/Downloads/orr-portal/node_modules/glob/glob.js:772:12)
    at lstatcb_ (/Users/lmcgibbn/Downloads/orr-portal/node_modules/glob/glob.js:764:12)
Emitted 'error' event on Domain instance at:
    at DestroyableTransform.EventEmitter.emit (domain.js:535:12)
    at Pumpify.emit (events.js:315:20)
    at Pumpify.EventEmitter.emit (domain.js:485:12)
    at Pumpify.Duplexify._destroy (/Users/lmcgibbn/Downloads/orr-portal/node_modules/duplexify/index.js:191:15)
    at /Users/lmcgibbn/Downloads/orr-portal/node_modules/duplexify/index.js:182:10
    at processTicksAndRejections (internal/process/task_queues.js:79:11) {
  domainEmitter: DestroyableTransform {
    _readableState: ReadableState {
      objectMode: true,
      highWaterMark: 16,
      buffer: BufferList { length: 0 },
      length: 0,
      pipes: [Pumpify],
      pipesCount: 1,
      flowing: true,
      ended: false,
      endEmitted: false,
      reading: true,
      sync: false,
      needReadable: true,
      emittedReadable: false,
      readableListening: false,
      resumeScheduled: false,
      destroyed: false,
      defaultEncoding: 'utf8',
      awaitDrain: 0,
      readingMore: false,
      decoder: null,
      encoding: null
    },
    readable: true,
    _events: [Object: null prototype] {
      end: [Array],
      prefinish: [Function: prefinish],
      pipe: [Function],
      data: [Function: ondata]
    },
    _eventsCount: 4,
    _maxListeners: undefined,
    _writableState: WritableState {
      objectMode: true,
      highWaterMark: 16,
      finalCalled: false,
      needDrain: false,
      ending: true,
      ended: true,
      finished: true,
      destroyed: false,
      decodeStrings: true,
      defaultEncoding: 'utf8',
      length: 0,
      writing: false,
      corked: 0,
      sync: true,
      bufferProcessing: false,
      onwrite: [Function (anonymous)],
      writecb: null,
      writelen: 0,
      bufferedRequest: null,
      lastBufferedRequest: null,
      pendingcb: 0,
      prefinished: true,
      errorEmitted: false,
      bufferedRequestCount: 0,
      corkedRequestsFree: [CorkedRequest]
    },
    writable: false,
    allowHalfOpen: true,
    _transformState: {
      afterTransform: [Function: bound afterTransform],
      needTransform: true,
      transforming: false,
      writecb: null,
      writechunk: null,
      writeencoding: null
    },
    _destroyed: false,
    _transform: [Function: forward],
    _flush: [Function: flush],
    [Symbol(kCapture)]: false
  },
  domainThrown: false
}

This looks more serious. The output is not verbose enough for me to decipher what is wrong.

I was able to launch gulp dev however the login and account creation windows no longer display properly.

I wonder if you can try the same and report out your results?

@lewismc lewismc requested a review from carueda July 17, 2020 23:34
Copy link
Member

@carueda carueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in some other related attempt in the past, jumping from angular 1.4.7 to 1.8.0 is HUGE ... so this would require quite a lot of effort, not sure if any of us have the cycles for that : (

@lewismc
Copy link
Member Author

lewismc commented Jul 17, 2020 via email

@@ -268,7 +269,6 @@ function app_min_css(cb) {

const vendorCssSources = [
'node_modules/bootstrap-css-only/css/bootstrap.css',
'node_modules/bootstrap-css-only/css/bootstrap-theme.css',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this CSS required for @carueda ? I couldn't find it with the updated dependencies. Do you know which package it comes from?

@lewismc
Copy link
Member Author

lewismc commented Jul 18, 2020

Everything now at least installs properly. That is to say npm install and gulp install --base=/ont/ --dest=DEST

@lewismc lewismc marked this pull request as draft July 18, 2020 04:04
@lewismc lewismc self-assigned this Jul 18, 2020
@lewismc lewismc added the dependencies Pull requests that update a dependency file label Jul 18, 2020
@lewismc
Copy link
Member Author

lewismc commented Jul 18, 2020

@lewismc
Copy link
Member Author

lewismc commented Jul 18, 2020

For the first time I've read the upgrading from AngularJS to Angular documentation... and this is pretty intimidating. It appears the guidance is to create a hybrid app (running both frameworks in parallel) before finally dropping support for the former. This is a huge undertaking and as I am not a JS developer this is beyond my capability.

Likewise @carueda writing the new app Quasar/Vue is also a pretty huge undertaking at this stage... I'm thinking that we should do a Capstone project to move this forward. This is a chunk of work...

@carueda
Copy link
Member

carueda commented Jul 18, 2020

Right, if upgrading just to a newer version of AngularJS is such a challenge, even worse to Angular, which is a different beast.

About the bootstrap css stuff, I would have to look closer ... but in any case, all of that manual preparation for the minified version that was required back then when this was implemented is by now so old fashioned ... definitely better to think about a revamped version with a modern framework like Vue. Again my opinion and preference due to very happy experience with Vue in general (and Quasar for the UI framework per se). We could discuss about possible Vue components that could incrementally be added to the "orrui" prototype...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants