Add Jetstream domain support #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@autodidaddict are you familiar with the jetstream domains? I haven't used them and would love to get some more expert opinion on this |
|
I am familiar. I'll take a closer look when I get to a non-phone. This should close #73 |
autodidaddict
approved these changes
Oct 10, 2023
mmmries
reviewed
Oct 12, 2023
mmmries
reviewed
Oct 12, 2023
mmmries
reviewed
Oct 12, 2023
mmmries
reviewed
Oct 12, 2023
|
@brandynbennett I think this is ready to be merged. Do you have any reservations on this? |
|
Looks like we need to do a We always check the formatting on CI jobs |
Good one! Did that now 👍 |
brandynbennett
approved these changes
Oct 19, 2023
|
This has been released as jetstream v0.0.9 Thanks @c0deaddict for the great PR and being open to feedback ❤️ 💛 💙 💚 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all thanks for this nice library! It helped us connecting our Elixir service to NATS JetStream 💯
We are in the process of migrating to a new NATS setup which uses Leaf Nodes (https://docs.nats.io/running-a-nats-service/configuration/leafnodes). For this we needed to use JetStream domains. This PR adds support for configuring an optional domain parameter to streams and consumers.
Tested this change in a service.