Skip to content

Commit

Permalink
fix(app, ios): adopt firebase-ios-sdk 10.22.0 (invertase#7668)
Browse files Browse the repository at this point in the history
* fix(app, ios): bump iOS SDK to v10.22.0

this should fix a compile issue with the new Xcode and the storage module

* test(ios): delete Podfile.lock on pod install

in practice this file is out of date and causes failures more often
than having it survive the install is useful.

github actions cache will still pull from the secondary key and get
reasonable caching behavior even if the lockfile hash changes

---------

Co-authored-by: Mike Hardy <[email protected]>
  • Loading branch information
VictorioMolina and mikehardy authored Mar 7, 2024
1 parent fc2c857 commit 3fc756b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion docs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ Open your projects `/ios/Podfile` and add any of the globals shown below to the

```ruby
# Override Firebase SDK Version
$FirebaseSDKVersion = '10.21.0'
$FirebaseSDKVersion = '10.22.0'
```

Once changed, reinstall your projects pods via pod install and rebuild your project with `npx react-native run-ios`.
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"tests:ios:test-reuse": "cd tests && SIMCTL_CHILD_GULGeneratedClassDisposeDisabled=1 yarn detox test --configuration ios.sim.debug --reuse --loglevel warn",
"tests:ios:test-cover": "cd tests && SIMCTL_CHILD_GULGeneratedClassDisposeDisabled=1 ./node_modules/.bin/nyc yarn detox test --configuration ios.sim.debug --loglevel warn",
"tests:ios:test-cover-reuse": "cd tests && SIMCTL_CHILD_GULGeneratedClassDisposeDisabled=1 node_modules/.bin/nyc yarn detox test --configuration ios.sim.debug --reuse --loglevel warn",
"tests:ios:pod:install": "cd tests && rm -rf ios/ReactNativeFirebaseDemo.xcworkspace && yarn pod-install",
"tests:ios:pod:install": "cd tests && rm -f ios/Podfile.lock && rm -rf ios/ReactNativeFirebaseDemo.xcworkspace && yarn pod-install",
"format:markdown": "prettier --write \"docs/**/*.md\""
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
},
"sdkVersions": {
"ios": {
"firebase": "10.21.0",
"firebase": "10.22.0",
"iosTarget": "11.0",
"macosTarget": "10.13"
},
Expand Down

0 comments on commit 3fc756b

Please sign in to comment.