Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Update BIDS Validator infrastructure #1303

Merged
merged 3 commits into from
Sep 2, 2024
Merged

MAINT: Update BIDS Validator infrastructure #1303

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4da33c4
try remove error
sappelhoff Sep 2, 2024
c4049dd
remove env vars, simplify install
sappelhoff Sep 2, 2024
a980506
updates to bids-validator infrastructure
sappelhoff Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mne_bids/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
@pytest.fixture(scope="session")
def _bids_validate():
"""Fixture to run BIDS validator."""
vadlidator_args = ["--config.error=41"]
# vadlidator_args = ["--config.error=41"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this really https://github.com/bids-standard/bids-validator/blob/690a34a5a723b8b436f19d9bc4da3b7a2acfaad4/bids-validator/utils/issues/list.js#L225-L229 ?

  41: {
    key: 'NIFTI_UNIT',
    severity: 'warning',
    reason:
      "NIfTI file's header field for unit information for x, y, z, and t dimensions empty or too short",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, got it. This was related to:

fixed in:

vadlidator_args = []
exe = os.getenv("VALIDATOR_EXECUTABLE", "bids-validator")

if platform.system() == "Windows":
Expand Down