-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Adding eye tracking to ch map #1344
Conversation
Hello! 👋 Thanks for opening your first pull request here! |
Let me know if the change in this PR is something you want to merge. If so, I'll go through the checklist to get it ready to merge. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1344 +/- ##
=======================================
Coverage 97.42% 97.42%
=======================================
Files 40 40
Lines 8883 8883
=======================================
Hits 8654 8654
Misses 229 229 ☔ View full report in Codecov by Sentry. |
Thanks for the contribution. I think we can merge this as a first step towards a more thorough eye tracking support. Please add a changelog entry and yourself to CITATION.cff as described here: https://github.com/mne-tools/mne-bids/blob/main/CONTRIBUTING.md#instructions-for-first-time-contributors |
@sappelhoff I think the contrib info is OK now. You should be good to merge whenever you want. |
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
Thanks @christian-oreilly |
PR Description
Very small PR just adding eye-tracking types to the channel mapping. Without this, MNE Raw objects with eye-tracking data cannot be exported to BIDS. Exporting with this change seems to fix the bug. We also had to make sure there were not NaNs in the raw objects using
but I did not include this in the PR as it seems like a larger issue.
Related to #1342. Not sure if enough to close that issue.
Merge checklist
Maintainer, please confirm the following before merging.
If applicable: