WIP Rework mne bids path match #1355
Conversation
…h are not files. Are there more folders in different datatypes allowed?
|
Hello! 👋 Thanks for opening your first pull request here! |
for more information, see https://pre-commit.ci
…h_match' into rework_mne_bids_path_match
pyproject.toml
Outdated
| @@ -52,6 +52,7 @@ doc = [ | |||
| "numpydoc", | |||
| "openneuro-py", | |||
| "pandas", | |||
| "pathlib", | |||
There was a problem hiding this comment.
it's part of the standard library and doesn't need to be listed here
There was a problem hiding this comment.
thx, this comes up though 🤔
/home/circleci/project/mne_bids/path.py:docstring of mne_bids.BIDSPath.root:1: WARNING: py:class reference target not found: pathlib._local.Path [ref.class]
There was a problem hiding this comment.
See #1358 (comment) . #1353 includes a work around for this but hasn't been merged yet
waldie11
force-pushed
the
rework_mne_bids_path_match
branch
from
412aaef to
09ba143
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1355 +/- ##
==========================================
- Coverage 97.43% 97.40% -0.04%
==========================================
Files 40 40
Lines 8903 8912 +9
==========================================
+ Hits 8675 8681 +6
- Misses 228 231 +3 ☔ View full report in Codecov by Sentry. |
PR Description
The workflow of using
pathlib.Path.rgloband subsequently filtering i.e. by each path starting withroot/sub-*is rather non-performant, especially on polluted storage trees.For starters, by using
glob.globrecursively directly, it is possible to apply this filter equivalent immediately.In an extension, I am suggesting to introduce the option of
include_matchtoget_entity_vals.Open to suggestions, or stripping this down.
Remark: I failed to join the CI as my email adress is considered work mail for some reason by MS.
Merge checklist
Maintainer, please confirm the following before merging.
If applicable: