-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: coreg legend #10459
ENH: coreg legend #10459
Conversation
This is ready for reviews from my end @agramfort, @larsoner |
mne/gui/_coreg.py
Outdated
@@ -746,6 +747,11 @@ def _configure_picking(self): | |||
self._on_pick | |||
) | |||
|
|||
def _configure_legend(self): | |||
mri_fids_legend_actor = self._renderer.legend( | |||
labels=[("LPA", "red"), ("Nasion", "green"), ("RPA", "blue")]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you avoid redefining here the colors of fiducials and define each color in only one place? besides can you use (0, 1, 0) for nasion in legend so it's more readable.
@agramfort I reused the values in |
I pushed a commit to fix:
|
Thank you @agramfort ! |
This PR adds a legend to the coreg app. It helps make the association fiducial <> color:
It's an item of #8833