Update to make the sheriff generator work again #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- copy urban dictionary script out because of bocong/urbandictionary-py#12 - change emoji library key name - minor codemod python 2->3 updates - set up poetry project
|
Sorry for my delay in replying--this looks great! My only comment is that the poetry dependency seems unnecessary, especially since there's now just one package requirement (emoji). Maybe you could either remove the poetry dependency, or make it clear that it's a separate/optional installation option in the readme? |
|
Ah, sorry @mobeets - I might be able to do that in a a separate PR - still getting a feel for the python universe so it may take a while to have time to revisit + reimplement without the main tool that i know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a bit of a python novice but i made some updates to make this thing work again. It included copying the urban dictionary script into this repo because that one has been fixed on
masterto accomodate a breaking api update not been released as an updated package. It also now usespoetry.👮
🖥️🖥️🖥️
🖥️ 🖥️ 🖥️
👇 💻💻 👇
💻 💻
💻 💻
👢 👢
Howdy, I'm the sheriff of computer. A tool] that is [supposed to] [save] time but intead wastes time.