Fixed the problem that packet id: "FAIL" was returned when UTF8 characters appeared in the "path" parameter of the "push" method. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d: FAIL" was thrown when UTF8 characters appeared in the path parameter of the push method.
|
Hey @flyfishxu, could you add a test for this? |
…filename or path. & Add related test.
|
No problem @bartekpacia ! I added a test for this problem, and when I write the test, I found that if CJK caracters appear in the path or filename, it will back "No such file or directory". Actually, they are by the same cause, and I fixed them now. |
bartekpacia
approved these changes
Sep 6, 2024
Leland-Takamine
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the period version, "java.io.IOException: Unexpected sync packet id: FAIL" was thrown when UTF8 characters appeared in the path parameter of the push method.
Because characters other than ASCII do not occupy only one byte in UTF8 encoding, so using the "remote.length" method to calculate the byte length will result in an incorrect length result, resulting in a "FAIL".