Retry get_connections on Graph API error code 2 #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will lint and update. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making large fetches with
get_all_connectionsrecently, we will often see it fail with a GraphAPIError with error code 2. The error is not common, maybe one in hundreds or even thousands of requests, but it fails out of the entire operation, which is frustrating.Facebook indicate that a simple wait and retry is suitable for these: https://developers.facebook.com/docs/graph-api/using-graph-api/error-handling/
Most that we have seen seem to almost immediately succeed if retried, so this adds a simple retry mechanism with basic defaults of 5 attempts with a 10 second delay between them.
Facebook does not seem to object to a 10 second delay before retrying and we have not seen it fail more than once in a row, so 5 seems fair as a measure highly likely to indicate something more serious is going on.