Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove mention that buildkit warns about unconsumned build args #4755

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

dvdksn
Copy link
Collaborator

@dvdksn dvdksn commented Mar 13, 2024

BuildKit doesn't warn if a provided build argument is not consumed,
unlike the classic builder.

relates to:

BuildKit doesn't warn if a provided build argument is not consumed,
unlike the classic builder.

Signed-off-by: David Karlsson <[email protected]>
@tonistiigi tonistiigi merged commit 6c0b576 into moby:master Mar 13, 2024
15 checks passed
@dvdksn dvdksn deleted the docs-buildarg-consume-nowarning branch March 13, 2024 17:31
@thaJeztah
Copy link
Member

Are there plans to fix this? (It's a regression compared to the classic builder)

@tonistiigi
Copy link
Member

#4751 but only if we can detect typos. Sending a build arg that is not used by a specific build is not something that should not be allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants