Updated Integration Testing on Windows #6370
Open
+76
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Natnael Gebremariam <[email protected]>
ngebremariam-msft
force-pushed
the
master
branch
from
8874a68 to
e0fe522
Compare
crazy-max
requested changes
Nov 18, 2025
client/__debug_bin.exe
Outdated
Member
There was a problem hiding this comment.
seems unattended binaries made there way in 🙈
Author
There was a problem hiding this comment.
I have now removed all of them.
.vscode/launch.json
Outdated
Member
There was a problem hiding this comment.
please remove this one as well
Signed-off-by: Natnael Gebremariam <[email protected]>
crazy-max
requested changes
Nov 21, 2025
Comment on lines
+7
to
+8
| client/__debug_bin.exe* | ||
| .vscode/ |
Member
There was a problem hiding this comment.
Should not be put in project's gitignore as well. If you need these to be ignored, it should be put in your global gitignore through core.excludesFile: https://git-scm.com/docs/gitignore#_configuration
Member
There was a problem hiding this comment.
Also squash your commits, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frontend/dockerfile:
Added explanations for why certain tests remain skipped on Windows and removed an unnecessary skip for Windows.
Changes:
Continued to skip testCopyLinkEmptyDestDir, testCopyLinkDotDestDir, and testTarExporterMulti, with explanations provided.
/client:
Changes:
Fixed the skip for testMoveParentDir and enabled compatibility for both Linux and Windows.
This pull request updates several integration tests to improve Windows compatibility.
Signed-off-by: Natnael Gebremariam [email protected]