Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listen on all interfaces by default, grunt-cli dep #186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Listen on all interfaces by default, grunt-cli dep #186

wants to merge 1 commit into from

Conversation

imran-uk
Copy link

@imran-uk imran-uk commented Feb 6, 2015

  • listen on all interfaces (0.0.0.0) by default
  • add helpful remark on how to enable that (saves hunting around to figure out how)
  • include grunt-cli in package.json for the grunt binary

Listen on all interfaces by default, grunt-cli dep
f6548b6 
* listen on all interfaces (0.0.0.0) by default
* add helpful remark on how to enable that (saves hunting around to figure out how)
* include grunt-cli in package.json for the grunt binary
@imran-uk
Copy link
Author

Is this pull request no good?

@philipskokoh
Copy link
Collaborator

Sorry, I am not aware of this PR until few days ago. May I know:

  1. What's the problem in the current behavior so that hostname: null is required?
  2. Why does grunt-cli need to be added? The current package.json is running fine now.

@jinleileiking jinleileiking mentioned this pull request Feb 27, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@imran-uk @philipskokoh