Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various bugs found while running OSACA on Cbrt #27

Merged
merged 5 commits into from
Jan 4, 2025
Merged

Various bugs found while running OSACA on Cbrt #27

merged 5 commits into from
Jan 4, 2025

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Jan 3, 2025

See mockingbirdnest/Principia#4157.

  • The (arch, syntax) trial logic was garbled.
  • Comments can be non-ASCII. Don’t try to be unnecessarily smart about non-ASCII.
  • The colour was not maxing out when generating the graph.
  • mul was missing.

@eggrobin eggrobin requested a review from pleroy January 3, 2025 16:58
@pleroy pleroy merged commit ca9b29a into mockingbirdnest:master Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleroy pleroy Awaiting requested review from pleroy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eggrobin @pleroy