Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show patched conics if the frame makes sense #3448

Merged
merged 1 commit into from
Oct 23, 2022

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Oct 23, 2022

Progress on #3441.

Displaying patched conics is a way to visualize the discrepancy between Princpia’s modeling and the approximations used by stock (chiefly patched conics, as in Figure 1, but also impulsive manœuvres, as in Figure 2).

Figure 1 Figure 2
screenshot4 screenshot2

However, enabling all patched conics leads to misleading display, as some conics, such as the trajectories of faraway planets, are displayed in a different reference frame (Figure 3). Depending on the choice of reference frame, all conics can be inappropriate, leading to a confusing mess (Figure 4).

Figure 3 Figure 4
screenshot0 screenshot5

This change avoids drawing most of the inappropriate conics. Further work is needed to avoid drawing those parts of a flight plan that are drawn as orbits about a parent of the current main body, as in Figure 5, which shows a planned conic in HCI but everything else in KCI.

Figure 5
screenshot7

@pleroy pleroy added the LGTM label Oct 23, 2022
@eggrobin eggrobin merged commit b26c192 into mockingbirdnest:master Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants