Only show patched conics if the frame makes sense #3448
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #3441.
Displaying patched conics is a way to visualize the discrepancy between Princpia’s modeling and the approximations used by stock (chiefly patched conics, as in Figure 1, but also impulsive manœuvres, as in Figure 2).
However, enabling all patched conics leads to misleading display, as some conics, such as the trajectories of faraway planets, are displayed in a different reference frame (Figure 3). Depending on the choice of reference frame, all conics can be inappropriate, leading to a confusing mess (Figure 4).
This change avoids drawing most of the inappropriate conics. Further work is needed to avoid drawing those parts of a flight plan that are drawn as orbits about a parent of the current main body, as in Figure 5, which shows a planned conic in HCI but everything else in KCI.