A test that uses Boost multiprecision to validate the platform libraries #3967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggrobin
approved these changes
Apr 7, 2024
Comment on lines
+32
to
+40
| max_sin_ulp_distance = | ||
| std::max(max_sin_ulp_distance, | ||
| ULPDistance(std::sin(α), static_cast<double>(Sin(α)))); | ||
| max_cos_ulp_distance = | ||
| std::max(max_cos_ulp_distance, | ||
| ULPDistance(std::cos(α), static_cast<double>(Cos(α)))); | ||
| } | ||
| EXPECT_EQ(1, max_sin_ulp_distance); | ||
| EXPECT_EQ(1, max_cos_ulp_distance); |
There was a problem hiding this comment.
This tells us that it sometimes misrounds, but it does not tell us that it is faithful, nor how much it misrounds. In a subsequent PR it would be nice to compute the distance between Sin(α) and std::sin(α) in (fractional) ULPs of static_cast<double>(Sin(α)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1760.