A basic accurate table generator #3975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggrobin
approved these changes
Apr 11, 2024
| EXPECT_THAT(static_cast<double>(x), | ||
| RelativeErrorFrom(5.0 / 128.0, IsNear(3.1e-14_(1)))); | ||
|
|
||
| // The stupid language doesn't allow printing a float in binary. So to verify |
There was a problem hiding this comment.
It might be useful to write a utility that prints a float in binary, or just produces a range of bits; this test is not exactly readable, and we will probably want to do more of that sort of thing.
There was a problem hiding this comment.
I'll need ToMathematica anyway for these Boost types, so that will be a better basis for checking the output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many things to be improved, notably:
#1760.