Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not preserve the sign in argument reduction if computing a Cos #4161

Merged
merged 9 commits into from
Jan 27, 2025
Merged

Do not preserve the sign in argument reduction if computing a Cos #4161

merged 9 commits into from
Jan 27, 2025

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Jan 27, 2025 •
edited
Loading

Comparison on Zen 3. Before:

RAW TSC:                         min      1‰      1%      5%     10%     25%     50%
            identity            4.94   +0.00   +0.00   +0.00   +0.38   +0.38   +0.38
    sqrtps_xmm0_xmm0           16.72   +0.00   +0.38   +0.38   +0.38   +0.38   +0.38
     mulsd_xmm0_xmm0            7.60   +0.00   +0.00   +0.00   +0.00   +0.00   +0.00
  mulsd_xmm0_xmm0_4x           15.20   +0.00   +0.00   +0.00   +0.00   +0.00   +0.00
Slope: 1.186186 cycle/TSC
Correlation coefficient: 0.999887
Cycles:             expected     min      1‰      1%      5%     10%     25%     50%
R           identity       0   -0.07   +0.00   +0.00   +0.00   +0.45   +0.45   +0.45
R    mulsd_xmm0_xmm0       3    3.08   +0.00   +0.00   +0.00   +0.00   +0.00   +0.00
R mulsd_xmm0_xmm0_4x      12   12.10   +0.00   +0.00   +0.00   +0.00   +0.00   +0.00
       principia_cos           65.73   +0.00   +0.00   +0.45   +0.45   +0.90   +0.90
       principia_sin           66.19   +0.00   +0.45   +0.45   +0.45   +0.90   +0.90
R   sqrtps_xmm0_xmm0      14   13.90   +0.45   +0.45   +0.45   +0.45   +0.45   +0.45
             std_cos           55.37   +0.45   +0.90   +0.90   +0.90   +0.90   +0.90
             std_sin           63.03   +0.00   +0.00   +0.00   +0.00   +0.00   +0.45

After:

RAW TSC:                         min      1‰      1%      5%     10%     25%     50%
            identity            4.94   +0.00   +0.00   +0.00   +0.38   +0.38   +0.38
    sqrtps_xmm0_xmm0           16.72   +0.38   +0.38   +0.38   +0.38   +0.38   +0.38
     mulsd_xmm0_xmm0            7.60   +0.00   +0.00   +0.00   +0.00   +0.00   +0.00
  mulsd_xmm0_xmm0_4x           15.20   +0.00   +0.00   +0.00   +0.00   +0.00   +0.00
Slope: 1.186186 cycle/TSC
Correlation coefficient: 0.999887
Cycles:             expected     min      1‰      1%      5%     10%     25%     50%
R           identity       0   -0.07   +0.00   +0.00   +0.00   +0.45   +0.45   +0.45
R    mulsd_xmm0_xmm0       3    3.08   +0.00   +0.00   +0.00   +0.00   +0.00   +0.00
R mulsd_xmm0_xmm0_4x      12   12.10   +0.00   +0.00   +0.00   +0.00   +0.00   +0.00
       principia_cos           63.48   +0.45   +0.45   +0.45   +0.90   +0.90   +0.90
       principia_sin           66.19   +0.45   +0.45   +0.45   +0.90   +0.90   +0.90
R   sqrtps_xmm0_xmm0      14   13.90   +0.45   +0.45   +0.45   +0.45   +0.45   +0.45
             std_cos           54.47   +0.45   +0.45   +0.45   +0.45   +0.90   +0.90
             std_sin           63.03   +0.00   +0.00   +0.00   +0.00   +0.00   +0.45

Comparison on Golden Cove. Before:

RAW TSC:                         min      1‰      1%      5%     10%     25%     50%
            identity            6.76   +0.08   +0.10   +0.14   +0.14   +0.18   +0.20
    sqrtps_xmm0_xmm0           27.10   +0.16   +0.20   +0.22   +0.26   +0.28   +0.34
     mulsd_xmm0_xmm0           14.04   +0.10   +0.16   +0.64   +0.66   +0.70   +0.72
  mulsd_xmm0_xmm0_4x           32.34   +0.12   +0.22   +1.32   +1.34   +1.38   +1.46
Slope: 0.621248 cycle/TSC
Correlation coefficient: 0.998706
Cycles:             expected     min      1‰      1%      5%     10%     25%     50%
R           identity       0   -0.29   +0.07   +0.09   +0.11   +0.11   +0.14   +0.16
R    mulsd_xmm0_xmm0       4    4.26   +0.05   +0.09   +0.19   +0.41   +0.43   +0.46
R mulsd_xmm0_xmm0_4x      16   15.58   +0.07   +0.14   +0.27   +0.88   +0.92   +0.97
       principia_cos           67.01   +0.48   +0.73   +1.04   +1.29   +1.85   +2.48
       principia_sin           67.93   +0.71   +1.01   +1.33   +1.53   +1.93   +2.70
R   sqrtps_xmm0_xmm0      12   12.40   +0.09   +0.11   +0.14   +0.16   +0.20   +0.29
             std_cos           54.78   +0.75   +0.89   +1.04   +1.12   +1.28   +1.57
             std_sin           64.05   +0.15   +0.24   +0.36   +0.46   +0.82   +1.21

After:

RAW TSC:                         min      1‰      1%      5%     10%     25%     50%
            identity            6.72   +0.12   +0.16   +0.18   +0.18   +0.22   +0.28
    sqrtps_xmm0_xmm0           27.08   +0.18   +0.22   +0.26   +0.28   +0.32   +0.36
     mulsd_xmm0_xmm0           13.96   +0.18   +0.26   +0.74   +0.74   +0.78   +0.80
  mulsd_xmm0_xmm0_4x           32.34   +0.10   +0.16   +1.30   +1.34   +1.38   +1.46
Slope: 0.619980 cycle/TSC
Correlation coefficient: 0.998773
Cycles:             expected     min      1‰      1%      5%     10%     25%     50%
R           identity       0   -0.25   +0.07   +0.10   +0.11   +0.11   +0.14   +0.17
R    mulsd_xmm0_xmm0       4    4.24   +0.11   +0.15   +0.45   +0.46   +0.48   +0.51
R mulsd_xmm0_xmm0_4x      16   15.59   +0.12   +0.22   +0.87   +0.89   +0.92   +0.95
       principia_cos           63.93   +1.46   +1.81   +2.12   +2.29   +2.59   +3.00
       principia_sin           67.92   +0.58   +0.91   +1.22   +1.40   +1.76   +2.42
R   sqrtps_xmm0_xmm0      12   12.39   +0.11   +0.14   +0.16   +0.19   +0.22   +0.31
             std_cos           54.97   +0.47   +0.63   +0.78   +0.86   +1.02   +1.28
             std_sin           63.92   +0.19   +0.27   +0.40   +0.51   +0.88   +1.25

pleroy added 9 commits January 12, 2025 00:03
@pleroy
Do not preserve the sign during reduction if evaluating a Cos.
6065459
@pleroy
More symmetry.
55c7c8e
@pleroy
Do not preserve the sign during reduction if evaluating a Cos.
4369b7b
@pleroy
Do not preserve the sign during reduction if evaluating a Cos.
43273b6 
Comparison on Zen3.  Before:
```
RAW TSC:                         min      1‰      1%      5%     10%     25%     50%
            identity            4.94   +0.00   +0.00   +0.00   +0.38   +0.38   +0.38
    sqrtps_xmm0_xmm0           16.72   +0.38   +0.38   +0.38   +0.38   +0.38   +0.38
     mulsd_xmm0_xmm0            7.60   +0.00   +0.00   +0.00   +0.00   +0.00   +0.00
  mulsd_xmm0_xmm0_4x           15.20   +0.00   +0.00   +0.00   +0.00   +0.00   +0.00
Slope: 1.186186 cycle/TSC
Correlation coefficient: 0.999887
Cycles:             expected     min      1‰      1%      5%     10%     25%     50%
R           identity       0   -0.07   +0.00   +0.00   +0.00   +0.45   +0.45   +0.45
R    mulsd_xmm0_xmm0       3    3.08   +0.00   +0.00   +0.00   +0.00   +0.00   +0.00
R mulsd_xmm0_xmm0_4x      12   12.10   +0.00   +0.00   +0.00   +0.00   +0.00   +0.00
       principia_cos           65.73   +0.00   +0.00   +0.45   +0.45   +0.90   +0.90
       principia_sin           64.83   +1.35   +1.80   +1.80   +1.80   +2.25   +2.25
R   sqrtps_xmm0_xmm0      14   13.90   +0.45   +0.45   +0.45   +0.45   +0.45   +0.45
             std_cos           55.37   +0.45   +0.90   +0.90   +0.90   +0.90   +0.90
             std_sin           63.03   +0.00   +0.00   +0.00   +0.00   +0.00   +0.45
```
After:
```
RAW TSC:                         min      1‰      1%      5%     10%     25%     50%
            identity            4.94   +0.00   +0.00   +0.00   +0.38   +0.38   +0.38
    sqrtps_xmm0_xmm0           16.72   +0.38   +0.38   +0.38   +0.38   +0.38   +0.38
     mulsd_xmm0_xmm0            7.60   +0.00   +0.00   +0.00   +0.00   +0.00   +0.00
  mulsd_xmm0_xmm0_4x           15.20   +0.00   +0.00   +0.00   +0.00   +0.00   +0.00
Slope: 1.186186 cycle/TSC
Correlation coefficient: 0.999887
Cycles:             expected     min      1‰      1%      5%     10%     25%     50%
R           identity       0   -0.07   +0.00   +0.00   +0.00   +0.45   +0.45   +0.45
R    mulsd_xmm0_xmm0       3    3.08   +0.00   +0.00   +0.00   +0.00   +0.00   +0.00
R mulsd_xmm0_xmm0_4x      12   12.10   +0.00   +0.00   +0.00   +0.00   +0.00   +0.00
       principia_cos           63.48   +3.61   +3.61   +4.06   +4.06   +4.06   +4.06
       principia_sin           69.34   +0.00   +0.45   +0.45   +0.45   +0.45   +0.90
R   sqrtps_xmm0_xmm0      14   13.90   +0.45   +0.45   +0.45   +0.45   +0.45   +0.45
             std_cos           54.47   +0.45   +0.45   +0.45   +0.45   +0.90   +0.90
             std_sin           63.03   +0.00   +0.00   +0.00   +0.00   +0.00   +0.45
```
Comparison on Golden Cove.  Before:
```
RAW TSC:                         min      1‰      1%      5%     10%     25%     50%
            identity            6.74   +0.22   +0.24   +0.26   +0.28   +0.30   +0.32
    sqrtps_xmm0_xmm0           26.94   +0.32   +0.34   +0.36   +0.38   +0.42   +0.46
     mulsd_xmm0_xmm0           14.04   +0.14   +0.58   +0.62   +0.64   +0.66   +0.70
  mulsd_xmm0_xmm0_4x           32.36   +0.10   +1.22   +1.28   +1.30   +1.34   +1.40
Slope: 0.622294 cycle/TSC
Correlation coefficient: 0.998924
Cycles:             expected     min      1‰      1%      5%     10%     25%     50%
R           identity       0   -0.23   +0.11   +0.11   +0.12   +0.14   +0.15   +0.16
R    mulsd_xmm0_xmm0       4    4.30   +0.06   +0.09   +0.36   +0.37   +0.39   +0.41
R mulsd_xmm0_xmm0_4x      16   15.64   +0.10   +0.19   +0.83   +0.85   +0.87   +0.91
       principia_cos           69.40   +0.35   +0.54   +0.71   +0.80   +0.97   +1.17
       principia_sin           70.49   +0.41   +0.58   +0.73   +0.82   +0.97   +1.15
R   sqrtps_xmm0_xmm0      12   12.44   +0.06   +0.09   +0.10   +0.11   +0.12   +0.15
             std_cos           55.23   +0.42   +0.52   +0.62   +0.68   +0.77   +0.88
             std_sin           64.13   +0.12   +0.20   +0.26   +0.30   +0.37   +0.46
```
After:
```
RAW TSC:                         min      1‰      1%      5%     10%     25%     50%
            identity            6.84   +0.14   +0.14   +0.16   +0.18   +0.20   +0.22
    sqrtps_xmm0_xmm0           27.14   +0.12   +0.14   +0.16   +0.18   +0.22   +0.26
     mulsd_xmm0_xmm0           14.16   +0.44   +0.48   +0.50   +0.52   +0.54   +0.56
  mulsd_xmm0_xmm0_4x           32.42   +1.14   +1.18   +1.22   +1.24   +1.28   +1.34
Slope: 0.622041 cycle/TSC
Correlation coefficient: 0.998720
Cycles:             expected     min      1‰      1%      5%     10%     25%     50%
R           identity       0   -0.26   +0.07   +0.07   +0.09   +0.10   +0.11   +0.12
R    mulsd_xmm0_xmm0       4    4.28   +0.05   +0.30   +0.31   +0.32   +0.34   +0.35
R mulsd_xmm0_xmm0_4x      16   15.60   +0.76   +0.78   +0.80   +0.81   +0.83   +0.87
       principia_cos           66.31   +0.47   +0.71   +0.95   +1.09   +1.34   +1.64
       principia_sin           70.76   +0.37   +0.55   +0.71   +0.81   +0.96   +1.16
R   sqrtps_xmm0_xmm0      12   12.37   +0.07   +0.09   +0.12   +0.15   +4.85   +4.89
             std_cos           55.29   +0.31   +0.45   +0.57   +0.66   +0.88  +22.36
             std_sin           64.01   +0.16   +0.24   +0.31   +0.36   +0.46   +1.02
```
@pleroy
Redundant computation.
9950902
@pleroy
Merge remote-tracking branch 'mockingbirdnest/master' into NoSignForCos
b4846ab
@pleroy
Merge
d8206da
@pleroy
Comment.
c5019e3
@pleroy
Comment.
1dc0634
@eggrobin eggrobin added the LGTM label Jan 27, 2025
@pleroy pleroy merged commit d719546 into mockingbirdnest:master Jan 27, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eggrobin eggrobin eggrobin approved these changes

Assignees
No one assigned
Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pleroy @eggrobin