Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use indirect calls for Sin and Cos #4164

Merged
merged 6 commits into from
Feb 5, 2025

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Feb 2, 2025

It removes some if statements, and more importantly gives a way to use the functions from the platform if needed (e.g., when loading a legacy save). The performance is unaffected.

This requires to call the non-thread-safe principia::numerics::_sin_cos::StaticInitialization before calling Sin or Cos.

@eggrobin eggrobin added the LGTM label Feb 5, 2025
@pleroy pleroy merged commit 61922c4 into mockingbirdnest:master Feb 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants