refactor and fix skip gold #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domchevskayaA
previously approved these changes
Dec 9, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the cycle scheduling logic by extracting delay and asset selection into separate methods, and adds logic to skip gold (XAU) trading during inappropriate times.
Key Changes:
- Extracted delay calculation logic into
select_delay()method - Extracted asset selection logic into
select_asset()method with added XAU skip functionality - Removed obsolete comment from
get_latest_asset()method
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| synth/validator/miner_data_handler.py | Removed outdated comment about returning the asset with the least count |
| neurons/validator.py | Refactored schedule_cycle() by extracting delay and asset selection logic into separate methods, and added XAU skip logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Thykof
force-pushed
the
refactor-and-fix-skip-gold
branch
from
c16a513 to
860c96e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.