refactor: should_skip_xau #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the XAU (Gold) market hours logic from the validator, eliminating the should_skip_xau function and its usage throughout the codebase. This simplifies the asset selection and simulation flow by removing market-specific scheduling constraints.
Key Changes:
- Removed the
should_skip_xauutility function that checked if XAU market was closed - Eliminated XAU-specific skip logic from asset selection and forward prompt methods
- Removed associated test coverage for XAU market hours behavior
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| synth/utils/opening_hours.py | Deleted entire file containing should_skip_xau function |
| neurons/validator.py | Removed import and two call sites checking if XAU should be skipped |
| tests/test_validator.py | Removed test case test_select_asset_gold that validated XAU skip behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.