Skip to content

add CI #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Thykof merged 7 commits into from
Jan 2, 2025
Merged

add CI #34

Thykof merged 7 commits into from
Jan 2, 2025

Conversation

@Thykof
Copy link
Member

@Thykof Thykof commented Dec 11, 2024 •
edited
Loading

CI:

  • code formating
  • tests: disabled for now
  • lint: pylint is giving us some remarks and score in the CI (we can improve to introduce a pylint score threshold and put remark in the "File changed" section of the PR)

@Thykof Thykof force-pushed the thykof/mod-1181-setup-cicd-for-synth-repo branch from d20be04 to 63ec721 Compare December 26, 2024 22:12
@Thykof
Copy link
Member Author

Thykof commented Dec 26, 2024

tests/test_rewards.py:1:0: R0401: Cyclic import (simulation -> simulation.validator -> simulation.validator.forward -> simulation.base.validator -> simulation.base.neuron) (cyclic-import)

@Thykof Thykof force-pushed the thykof/mod-1181-setup-cicd-for-synth-repo branch 2 times, most recently from 22203ea to 9d6107d Compare December 27, 2024 15:54
@Thykof
Copy link
Member Author

Thykof commented Dec 27, 2024 •
edited
Loading

the pylint linter find many things but is not failing the CI

@Thykof Thykof force-pushed the thykof/mod-1181-setup-cicd-for-synth-repo branch from 9d6107d to 1df2376 Compare December 27, 2024 15:58
@Thykof Thykof force-pushed the thykof/mod-1181-setup-cicd-for-synth-repo branch from 1df2376 to 7480c14 Compare December 27, 2024 16:00
@Thykof Thykof marked this pull request as ready for review January 2, 2025 14:25
@Thykof Thykof requested a review from parkhomenko January 2, 2025 14:25
@Thykof Thykof merged commit 0536caf into main Jan 2, 2025
1 check passed
@Thykof Thykof deleted the thykof/mod-1181-setup-cicd-for-synth-repo branch January 2, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parkhomenko parkhomenko parkhomenko approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Thykof @parkhomenko