chore: sync with main (post PR #182 cleanup) #162
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add shared makeToolResult helper to server-utils.ts that supports both: - Legacy format: JSON-stringified text in content[0].text - New format: data in structuredContent field (when STRUCTURED_CONTENT_ONLY=true) Updated all example servers to use makeToolResult for tool results. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Update all example app clients to handle STRUCTURED_CONTENT_ONLY mode. When structuredContent is present in tool results, use it directly instead of parsing JSON from content text. Affected apps: - basic-server-vanillajs - budget-allocator-server - customer-segmentation-server - system-monitor-server - wiki-explorer-server 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Add try/catch around JSON.parse in all example apps - Log parse errors with context for debugging - Add debug logging to makeToolResult helper 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
commit: |
Resolved conflicts in example server.ts files: - Combined package imports (@modelcontextprotocol/ext-apps/server) with makeToolResult import from shared/server-utils.js 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
The learn_threejs tool doesn't have a UI component - it only returns documentation text. Using registerAppTool without _meta causes a runtime error when the function tries to access config._meta.ui. Fixes crash: "Cannot read property 'ui' of undefined" 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
ochafik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR syncs the branch with main after the significant restructuring in PR #182.
Original Goal (STRUCTURED_CONTENT_ONLY mode)
The original PR aimed to add
structuredContentsupport to examples. However, PR #182 restructured the examples to be self-contained, which conflicts with the sharedserver-utils.tsapproach.Current State
startalias forexamples:start#183)examples/shared/server-utils.tsOptions
server-utils.tsThe
structuredContentfeature (server returns structured data instead of JSON text, client handles both) is still valuable for demonstrating MCP capabilities but would need to be implemented differently given the new structure.🤖 Generated with Claude Code