fix: defer initial size measurement to ResizeObserver #189
+1
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143
Problem
setupSizeChangedNotifications()was measuring DOM size immediately afterconnect(), before async content (maps, data fetches) could load. This caused widgets to report their loading spinner height (~110px) instead of final content height, resulting in clipped content.Reproduction Flow
Solution
Remove the immediate
sendBodySizeChanged()call and rely purely onResizeObserver, which fires when content actually renders and changes size.Before (line 982)
After
Why This Works
ResizeObserveralready monitorsdocument.documentElementanddocument.bodyResizeObserverwhen it loadsTesting
npm test)npm run test:e2e)