-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Allow setting the timeout with the "timeout" URL parameter #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting the timeout with the "timeout" URL parameter #100
Conversation
ashwin-ant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
Build failing - think it is related to this commit in the SDK: modelcontextprotocol/typescript-sdk@e911ece Will fix. |
|
@evalstate I have a PR open to update the SDK #101 |
|
OK. I've added a commit - I'll wait for your PR to go through and merge. Best. |
|
Sorry about the breakage here! Per discussion on #101, didn't mean to release this breaking change—working on fixing it up now 😟 |
|
@evalstate I've updated the SDK to 1.0.3, mind rebasing this PR (and removing the second commit)? |
2384f75 to
e7d68a0
Compare
57c36ab to
bd6a636
Compare
|
Rebased; commits tidied. |
Allow setting the timeout with the "timeout" URL parameter
Allows setting the Request Timeout in milliseconds with a "timeout" URL parameter
Motivation and Context
Enables testing of tools which take > 10s to respond.
How Has This Been Tested?
This has been tested using the mcp-everything server
Breaking Changes
No breaking changes.
Types of changes
Checklist
Additional context
@ashwin-ant this is intended to cover simple cases - I considered matching progress updates to requestids to reset the timer - but that seems over-engineered for the need.