Skip to content

Conversation

@jeffreyling
Copy link
Contributor

@jeffreyling jeffreyling commented Dec 6, 2024

Addresses #96

Fixed issue with quoted arguments not being parsed properly in the MCP Inspector.

  • Added shell-quote package for proper argument parsing
  • Replace simple whitespace split with shellParseArgs
  • Ensures quoted arguments (like paths with spaces) are properly handled

This change was written and tested by Devin, and I also verified the change myself.

Motivation and Context

Fixes the shell argument parsing issue reported in #96.

How Has This Been Tested?

Tested with Devin
Screenshot 2024-12-06 at 11 53 04 AM

The arguments are now being parsed correctly with spaces. I also verified the change manually using a local deployment.

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Link to Devin run: https://preview.devin.ai/devin/57e4210f06024a688ba0009fe2e2ddcb

Copy link
Member

@ashwin-ant ashwin-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ashwin-ant ashwin-ant merged commit 0346995 into modelcontextprotocol:main Dec 7, 2024
2 checks passed
IgnacioC44 referenced this pull request in MCPJam/inspector Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants