Skip to content

Add enum support #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions client/src/components/DynamicJsonForm.tsx
Original file line number Diff line number Diff line change
@@ -17,6 +17,7 @@ export type JsonSchemaType = {
description?: string;
properties?: Record<string, JsonSchemaType>;
items?: JsonSchemaType;
enum?: string[];
};

type JsonObject = { [key: string]: JsonValue };
51 changes: 51 additions & 0 deletions client/src/components/StringInput.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
import { Textarea } from "@/components/ui/textarea";
import { JsonSchemaType } from "./DynamicJsonForm";
import {
Select,
SelectContent,
SelectItem,
SelectTrigger,
SelectValue,
} from "./ui/select";

interface Props {
id: string;
name: string;
property: JsonSchemaType;
value: string;
onChange: (value: string) => void;
}

export const StringInput = ({ id, name, property, value, onChange }: Props) => {
if (property.enum?.length) {
return (
<Select
value={value}
onValueChange={(value) => {
onChange(value);
}}
>
<SelectTrigger id={id} name={name}>
<SelectValue placeholder={property.description} />
</SelectTrigger>
<SelectContent>
{property.enum.map((item) => (
<SelectItem key={item} value={item}>
{item}
</SelectItem>
))}
</SelectContent>
</Select>
);
}

return (
<Textarea
id={id}
name={name}
placeholder={property.description}
value={value}
onChange={(e) => onChange(e.target.value)}
/>
);
};
26 changes: 12 additions & 14 deletions client/src/components/ToolsTab.tsx
Original file line number Diff line number Diff line change
@@ -4,7 +4,6 @@ import { Checkbox } from "@/components/ui/checkbox";
import { Input } from "@/components/ui/input";
import { Label } from "@/components/ui/label";
import { TabsContent } from "@/components/ui/tabs";
import { Textarea } from "@/components/ui/textarea";
import DynamicJsonForm, { JsonSchemaType, JsonValue } from "./DynamicJsonForm";
import {
ListToolsResult,
@@ -16,6 +15,7 @@ import { useEffect, useState } from "react";
import ListPane from "./ListPane";

import { CompatibilityCallToolResult } from "@modelcontextprotocol/sdk/types.js";
import { StringInput } from "./StringInput";

const ToolsTab = ({
tools,
@@ -192,19 +192,17 @@ const ToolsTab = ({
</label>
</div>
) : prop.type === "string" ? (
<Textarea
id={key}
name={key}
placeholder={prop.description}
value={(params[key] as string) ?? ""}
onChange={(e) =>
setParams({
...params,
[key]: e.target.value,
})
}
className="mt-1"
/>
<div className="mt-1">
<StringInput
id={key}
name={key}
property={prop}
value={(params[key] as string) ?? ""}
onChange={(value) =>
setParams({ ...params, [key]: value })
}
/>
</div>
) : prop.type === "object" || prop.type === "array" ? (
<div className="mt-1">
<DynamicJsonForm