Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 Add clear button for error notifications #286

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Cloudkkk
Copy link

@Cloudkkk Cloudkkk commented Apr 9, 2025

Add clear button for error notifications in MCP Inspector

Motivation and Context

Currently, there's no way to clear error notifications in the MCP Inspector UI, which can lead to a cluttered interface especially during long debugging sessions. This feature adds a clear button that allows users to remove all error notifications when they are no longer needed, improving the overall user experience.

How Has This Been Tested?

  • Tested in local development environment with MCP Inspector
  • Verified clear functionality works with both single and multiple error notifications
  • Tested button UI appearance in both light and dark themes
  • Verified state management properly clears all notifications

Breaking Changes

No breaking changes. This is a purely additive UI feature that doesn't affect existing functionality.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

  • Implemented through prop drilling pattern from App to Sidebar component
  • State management handled through React useState hook in App component
  • Button positioned next to error output title for intuitive UX

@cliffhall
Copy link
Contributor

Hi @Cloudkkk!

Can you add a screenshot / video of operation?

Also, it currently doesn't build.
Screenshot 2025-04-11 at 1 30 38 PM

@cliffhall cliffhall added enhancement New feature or request waiting on submitter Waiting for the submitter to provide more info labels Apr 11, 2025
@Cloudkkk
Copy link
Author

Hi @Cloudkkk!

Can you add a screenshot / video of operation?

Also, it currently doesn't build. Screenshot 2025-04-11 at 1 30 38 PM

Sorry ,I found that the Jest test case was indeed reporting errors and I have added the missing properties.
Also, here is the screenshot, please check it ~
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request waiting on submitter Waiting for the submitter to provide more info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants