Skip to content
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion client/src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ import { SESSION_KEYS, getServerSpecificKey } from "./lib/constants";
import { AuthDebuggerState, EMPTY_DEBUGGER_STATE } from "./lib/auth-types";
import { OAuthStateMachine } from "./lib/oauth-state-machine";
import { cacheToolOutputSchemas } from "./utils/schemaUtils";
import { cleanParams } from "./utils/paramUtils";
import type { JsonSchemaType } from "./utils/jsonUtils";
import React, {
Suspense,
useCallback,
Expand Down Expand Up @@ -777,12 +779,18 @@ const App = () => {
lastToolCallOriginTabRef.current = currentTabRef.current;

try {
// Find the tool schema to clean parameters properly
const tool = tools.find((t) => t.name === name);
const cleanedParams = tool?.inputSchema
? cleanParams(params, tool.inputSchema as JsonSchemaType)
: params;

const response = await sendMCPRequest(
{
method: "tools/call" as const,
params: {
name,
arguments: params,
arguments: cleanedParams,
_meta: {
progressToken: progressTokenRef.current++,
},
Expand Down
55 changes: 41 additions & 14 deletions client/src/components/ToolsTab.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -159,16 +159,27 @@ const ToolsTab = ({
id={key}
name={key}
placeholder={prop.description}
value={(params[key] as string) ?? ""}
onChange={(e) =>
setParams({
...params,
[key]:
e.target.value === ""
? undefined
: e.target.value,
})
value={
params[key] === undefined
? ""
: String(params[key])
}
onChange={(e) => {
const value = e.target.value;
if (value === "") {
// Field cleared - set to undefined
setParams({
...params,
[key]: undefined,
});
} else {
// Field has value - keep as string
setParams({
...params,
[key]: value,
});
}
}}
className="mt-1"
/>
) : prop.type === "object" || prop.type === "array" ? (
Expand Down Expand Up @@ -199,13 +210,29 @@ const ToolsTab = ({
id={key}
name={key}
placeholder={prop.description}
value={(params[key] as string) ?? ""}
value={
params[key] === undefined
? ""
: String(params[key])
}
onChange={(e) => {
const value = e.target.value;
setParams({
...params,
[key]: value === "" ? "" : Number(value),
});
if (value === "") {
// Field cleared - set to undefined
setParams({
...params,
[key]: undefined,
});
} else {
// Field has value - convert to number (never store strings)
const num = Number(value);
if (!isNaN(num)) {
setParams({
...params,
[key]: num,
});
}
}
}}
className="mt-1"
/>
Expand Down
208 changes: 208 additions & 0 deletions client/src/utils/__tests__/paramUtils.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,208 @@
import { cleanParams } from "../paramUtils";
import type { JsonSchemaType } from "../jsonUtils";

describe("cleanParams", () => {
it("should preserve required fields even when undefined", () => {
const schema: JsonSchemaType = {
type: "object",
required: ["requiredString", "requiredNumber"],
properties: {
requiredString: { type: "string" },
requiredNumber: { type: "number" },
optionalString: { type: "string" },
optionalNumber: { type: "number" },
},
};

const params = {
requiredString: undefined,
requiredNumber: undefined,
optionalString: undefined,
optionalNumber: undefined,
};

const cleaned = cleanParams(params, schema);

expect(cleaned).toEqual({
requiredString: undefined,
requiredNumber: undefined,
// optionalString and optionalNumber should be omitted
});
});

it("should omit optional fields with empty strings", () => {
const schema: JsonSchemaType = {
type: "object",
required: [],
properties: {
optionalString: { type: "string" },
optionalNumber: { type: "number" },
},
};

const params = {
optionalString: "",
optionalNumber: "",
};

const cleaned = cleanParams(params, schema);

expect(cleaned).toEqual({});
});

it("should omit optional fields with undefined values", () => {
const schema: JsonSchemaType = {
type: "object",
required: [],
properties: {
optionalString: { type: "string" },
optionalNumber: { type: "number" },
},
};

const params = {
optionalString: undefined,
optionalNumber: undefined,
};

const cleaned = cleanParams(params, schema);

expect(cleaned).toEqual({});
});

it("should omit optional fields with null values", () => {
const schema: JsonSchemaType = {
type: "object",
required: [],
properties: {
optionalString: { type: "string" },
optionalNumber: { type: "number" },
},
};

const params = {
optionalString: null,
optionalNumber: null,
};

const cleaned = cleanParams(params, schema);

expect(cleaned).toEqual({});
});

it("should preserve optional fields with meaningful values", () => {
const schema: JsonSchemaType = {
type: "object",
required: [],
properties: {
optionalString: { type: "string" },
optionalNumber: { type: "number" },
optionalBoolean: { type: "boolean" },
},
};

const params = {
optionalString: "hello",
optionalNumber: 42,
optionalBoolean: false, // false is a meaningful value
};

const cleaned = cleanParams(params, schema);

expect(cleaned).toEqual({
optionalString: "hello",
optionalNumber: 42,
optionalBoolean: false,
});
});

it("should handle mixed required and optional fields", () => {
const schema: JsonSchemaType = {
type: "object",
required: ["requiredField"],
properties: {
requiredField: { type: "string" },
optionalWithValue: { type: "string" },
optionalEmpty: { type: "string" },
optionalUndefined: { type: "number" },
},
};

const params = {
requiredField: "",
optionalWithValue: "test",
optionalEmpty: "",
optionalUndefined: undefined,
};

const cleaned = cleanParams(params, schema);

expect(cleaned).toEqual({
requiredField: "",
optionalWithValue: "test",
});
});

it("should handle schema without required array", () => {
const schema: JsonSchemaType = {
type: "object",
properties: {
field1: { type: "string" },
field2: { type: "number" },
},
};

const params = {
field1: "",
field2: undefined,
};

const cleaned = cleanParams(params, schema);

expect(cleaned).toEqual({});
});

it("should preserve zero values for numbers", () => {
const schema: JsonSchemaType = {
type: "object",
required: [],
properties: {
optionalNumber: { type: "number" },
},
};

const params = {
optionalNumber: 0,
};

const cleaned = cleanParams(params, schema);

expect(cleaned).toEqual({
optionalNumber: 0,
});
});

it("should handle the new undefined-first approach (no empty strings)", () => {
const schema: JsonSchemaType = {
type: "object",
required: ["requiredField"],
properties: {
requiredField: { type: "string" },
optionalField: { type: "string" },
},
};

// New behavior: cleared fields are undefined, never empty strings
const params = {
requiredField: undefined, // cleared required field
optionalField: undefined, // cleared optional field
};

const cleaned = cleanParams(params, schema);

expect(cleaned).toEqual({
requiredField: undefined, // required field preserved as undefined
// optionalField omitted entirely
});
});
});
34 changes: 34 additions & 0 deletions client/src/utils/paramUtils.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
import type { JsonSchemaType } from "./jsonUtils";

/**
* Cleans parameters by removing undefined, null, and empty string values for optional fields
* while preserving all values for required fields.
*
* @param params - The parameters object to clean
* @param schema - The JSON schema defining which fields are required
* @returns Cleaned parameters object with optional empty fields omitted
*/
export function cleanParams(
params: Record<string, unknown>,
schema: JsonSchemaType,
): Record<string, unknown> {
const cleaned: Record<string, unknown> = {};
const required = schema.required || [];

for (const [key, value] of Object.entries(params)) {
const isFieldRequired = required.includes(key);

if (isFieldRequired) {
// Required fields: always include, even if empty string or falsy
cleaned[key] = value;
} else {
// Optional fields: only include if they have meaningful values
if (value !== undefined && value !== "" && value !== null) {
cleaned[key] = value;
}
// Empty strings, undefined, null for optional fields → omit completely
}
}
Comment on lines +21 to +31
Copy link
Member

@cliffhall cliffhall Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a simplification:

Suggested change
if (isFieldRequired) {
// Required fields: always include, even if empty string or falsy
cleaned[key] = value;
} else {
// Optional fields: only include if they have meaningful values
if (value !== undefined && value !== "" && value !== null) {
cleaned[key] = value;
}
// Empty strings, undefined, null for optional fields → omit completely
}
}
// Include all required fields, and optional fields if they have meaningful values
if (isFieldRequired || (value !== undefined && value !== "" && value !== null)) {
cleaned[key] = value;
}


return cleaned;
}
Loading