fix: filter out empty strings in server arguments to prevent parseArgs error #680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s error When running 'npx .' without any arguments, empty strings were being passed as positional arguments to the server, causing Node.js parseArgs to fail with 'Unexpected argument' error. This fix filters out empty strings from the arguments array before passing them to spawnPromise. Also added a test to verify the web client can start without any arguments, preventing regression of this issue.
🎭 Playwright E2E Test Results✅ 15 passed Details15 tests across 2 suites 📊 View Detailed HTML Report (download artifacts) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
npx .without arguments would crash with 'Unexpected argument' errorChanges
Test plan
npx .works without crashingnpx .starts the web client successfully