Skip to content

fix windows issue with bin/cli.js #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ashwin-ant wants to merge 2 commits into from
Closed

fix windows issue with bin/cli.js #78

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce7b57e
fix windows issue with bin/cli.js
ashwin-ant Nov 26, 2024
7535fc0
Update bin/cli.js
ashwin-ant Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions bin/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,15 @@ function escapeArg(arg) {
return arg;
}

function buildCommandWithPort(command, port) {
if (!port) return command;

if (process.platform === 'win32') {
return `set PORT=${port} && ${command}`;
}
return `PORT=${port} ${command}`;
}

const serverCommand = [
`node`,
inspectorServerPath,
Expand All @@ -34,17 +43,18 @@ const serverCommand = [
.filter(Boolean)
.join(" ");

const clientCommand = `node ${inspectorClientPath}`;
const CLIENT_PORT = process.env.CLIENT_PORT ?? "";
const SERVER_PORT = process.env.SERVER_PORT ?? "";

const { result } = concurrently(
[
{
command: `PORT=${SERVER_PORT} ${serverCommand}`,
command: buildCommandWithPort(serverCommand, SERVER_PORT),
name: "server",
},
{
command: `PORT=${CLIENT_PORT} node ${inspectorClientPath}`,
command: buildCommandWithPort(clientCommand, CLIENT_PORT),
name: "client",
},
],
Expand Down