Add Runtime Type Validation for Tool Results #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsp-ant
previously approved these changes
Nov 26, 2024
Member
dsp-ant
left a comment
dsp-ant
left a comment
There was a problem hiding this comment.
Thank you for the improvement! This is quite sensible.
ashwin-ant
previously approved these changes
Nov 26, 2024
Member
ashwin-ant
left a comment
ashwin-ant
left a comment
There was a problem hiding this comment.
Thank you! Left one small comment
client/src/components/ToolsTab.tsx
Outdated
| </pre> | ||
| <h4 className="font-semibold mb-2">Errors:</h4> | ||
| {parsedResult.error.errors.map((error) => ( | ||
| <pre className="bg-gray-50 dark:bg-gray-800 dark:text-gray-100 p-4 rounded text-sm overflow-auto max-h-64"> |
Member
There was a problem hiding this comment.
nit: I think this might need a key prop
Contributor
Author
There was a problem hiding this comment.
@ashwin-ant Perfect! I've applied your suggestion.
ashwin-ant
reviewed
Nov 26, 2024
Co-authored-by: ashwin-ant <[email protected]>
jacksteamdev
dismissed stale reviews from ashwin-ant and dsp-ant
via
6057831
ashwin-ant
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80
Problem
The inspector crashes when tool handlers return malformed responses. Specifically, when following the weather example from the docs, the inspector throws
TypeError: f.content.map is not a functionbecause the response structure doesn't match expectations.Solution
Changes
safeParse()to validate without throwingTesting