zod4 compatibility fixed for CI #939
Merged
+251
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎭 Playwright E2E Test Results✅ 24 passed Details24 tests across 3 suites 📊 View Detailed HTML Report (download artifacts) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes build errors from
npm install --no-package-lock.Although package.json had
^1.20.1the--no-package-lockwas still bringing in the latest version of the SDK (1.23.0at time of writing). This was causing build failures in the CI build/publish workflow which uses--no-package-lockin it's build pipeline. Locked builds were passing.This PR makes inspector code compatible with
1.23.0and updates thepackage.jsonso that both locked and lock-free installs build.This also updates prettier from
3.6.2to3.7.1. Similar to the above issue,3.7.1was being installed in the CI environment and failing on issues3.6.2was not.Type of Change
Changes Made
ZodError changed from
errors.errorstoerror.issues(ToolResults)$ZodObject->$ZodType(sendMCPRequest)z.output<T>-> `SchemaOutput (works with both v3 and v4)Migrate
Related Issues
Testing
Test Results and/or Instructions
Checklist
npm run prettier-fix)Breaking Changes
Additional Context
https://discord.com/channels/1358869848138059966/1443632409844383905