fix(security): add input validation to CLI to prevent command injection #990
+462
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add isValidEnvVarName() to validate env var names match [a-zA-Z_][a-zA-Z0-9_]* - Add isValidEnvVarValue() to reject values with null bytes - Add validateEnvVars() to filter invalid env vars with warnings - Add validateServerUrl() to validate URL protocol and warn on private IPs - Add validateCommand() to check for shell metacharacters and verify command exists - Apply validation in runWebClient() and runCli() functions - Add 11 integration tests for validation functions Security Impact: - Prevents command injection via malicious env var names - Prevents string truncation via null bytes in values - Warns users about connecting to internal addresses 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds input validation to the CLI to prevent potential command injection vulnerabilities.
Changes
isValidEnvVarName()- validates env var names match[a-zA-Z_][a-zA-Z0-9_]*isValidEnvVarValue()- rejects values containing null bytesvalidateEnvVars()- filters invalid env vars with warningsvalidateServerUrl()- validates URL protocol, warns on private IPsvalidateCommand()- checks for shell metacharacters, verifies command existsrunWebClient()andrunCli()functionsSecurity Impact
Test plan
npm run build)🤖 Generated with Claude Code