fix(security): add SSRF protection to URL validation #991
+217
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add isPrivateHostname() helper with comprehensive private IP detection: - Localhost variants (localhost, 127.x.x.x) - IPv4 private ranges (10.x, 172.16-31.x, 192.168.x, 169.254.x, 0.x) - IPv6 private ranges (::1, fe80::, fc00::, fd00::) - Cloud metadata endpoints (169.254.169.254, metadata.*) - Update validateRedirectUrl() to block private IPs by default - Add allowPrivateIPs option for backward compatibility - Add isPrivateUrl() utility function for checking without throwing - Add 18 unit tests for SSRF protection Security Impact: - Prevents SSRF attacks via OAuth redirect URLs - Blocks access to cloud metadata endpoints (AWS/GCP) - Covers IPv4 and IPv6 private ranges 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds SSRF (Server-Side Request Forgery) protection to URL validation by blocking requests to private/internal IP addresses.
Changes
isPrivateHostname()helper with comprehensive private IP detection:validateRedirectUrl()to block private IPs by defaultallowPrivateIPsoption for backward compatibilityisPrivateUrl()utility function for checking without throwingSecurity Impact
Test plan
npm run build)allowPrivateIPs: trueallows private IPs for backward compatibility🤖 Generated with Claude Code