Skip to content

Conversation

@devcrocod
Copy link
Contributor

  • use dynamic port

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@devcrocod devcrocod requested review from sdubov and tiginamaria August 4, 2025 11:11
Copy link
Contributor

@tiginamaria tiginamaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Am I right that the issue was that the static port can sometimes be in use on macOS or in CI environments, so assigning a dynamic port in tests is just safer?

@devcrocod
Copy link
Contributor Author

@tiginamaria
yes, back when there were fewer targets, server had enough time to be released

@devcrocod devcrocod merged commit 75d63c8 into main Aug 4, 2025
2 of 5 checks passed
@devcrocod devcrocod deleted the devcrocod/fix-macosArm-test branch August 4, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants