Remove useless ModelContextProtocol::JsonRPC module
#15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSON-RPC is handled by https://github.com/Shopify/json-rpc-handler, so `ModelContextProtocol::JsonRPC` module seems to have been unintentionally left behind in the following commit: modelcontextprotocol@c5591be The files under `model_context_protocol/json_rpc/*.rb` have already been removed.
koic
force-pushed
the
remove_useless_mcp_json_rpc_module
branch
from
2fe97d3 to
5f7a5b5
Compare
topherbullock
approved these changes
May 21, 2025
Contributor
|
🚮 ty @koic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
JSON-RPC is handled by https://github.com/Shopify/json-rpc-handler, so
ModelContextProtocol::JsonRPCmodule seems to have been unintentionally left behind in the following commit: c5591beThe files under
model_context_protocol/json_rpc/*.rbhave already been removed.Types of changes
Checklist