Skip to content

fix(fetch): fall back without readability js - #4200

Closed
he-yufeng wants to merge 1 commit into
modelcontextprotocol:mainfrom
he-yufeng:fix/fetch-readability-node-fallback
Closed

fix(fetch): fall back without readability js#4200
he-yufeng wants to merge 1 commit into
modelcontextprotocol:mainfrom
he-yufeng:fix/fetch-readability-node-fallback

Conversation

@he-yufeng

Copy link
Copy Markdown

Summary:

  • avoid the optional Readability.js path when Node.js is not available
  • add a --no-readability-js switch for environments where the Node.js simplifier is installed but problematic
  • document the fallback behavior and cover both default and opt-out paths in fetch tests

Fixes #4199.

To verify:

  • uv run pytest tests -q
  • uv run ruff check src tests
  • uv run pyright src
  • git diff --check

@he-yufeng
he-yufeng force-pushed the fix/fetch-readability-node-fallback branch from 476dff3 to aef5771 Compare May 31, 2026 21:32

@LuuOW LuuOW left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical audit: Verified MCP server implementation for consistency with current SDK patterns.

@he-yufeng

Copy link
Copy Markdown
Author

Superseded by #4281, which fixes the same "Node missing → Readability.js unavailable" problem (#4199) with an automatic Python fallback rather than a new opt-out flag. Consolidating on that one so there aren't three PRs touching the same fetch files — closing this.

@he-yufeng he-yufeng closed this Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mcp-server-fetch hard-codes use_readability=True which requires Node.js (undeclared); fails silently when Node is unavailable or misconfigured

2 participants