-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zlib v1.3.1 as submodule #4443
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make: *** No rule to make target '../../C-Sources/zlib/adler32.c', needed by '../../C-Sources/zlib/adler32.lo'. Stop.
@HansOlsson Did you remember to run |
I will check that later. I assume a similar procedure is needed there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with ./configure
and make
Ah I see. OK I guess @beutlich will look into this later. |
Yes, alread noticed but it is not obvious how to fix the Jenkinsfile. @sjoelund Please advice. |
This introduces the zlib dependency as git submodule instead of copying the source files over.
Note, that 62848d3 introduced a change to "our" zlib which is not available in zlib upstream. If you see an issue here to revert that change we could also add the dependency from a custom fork, e.g. https://github.com/modelica/zlib.
Note, that the submodule is added via HTTPS, not SSH.