Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant text in celsius to kelvin icon #4466

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qnikil7
Copy link

@qnikil7 qnikil7 commented Sep 18, 2024

Removed highlighted text.
image

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2024

CLA assistant check
All committers have signed the CLA.

@qnikil7 qnikil7 force-pushed the bugfix/to-kelvin-icon branch from 19f1c46 to f87e36b Compare September 18, 2024 14:44
@beutlich beutlich changed the title Removed redundent text in celcius to kelvin icon Removed redundant text in celcius to kelvin icon Sep 18, 2024
@beutlich beutlich added L: Thermal.HeatTransfer Issue addresses Modelica.Thermal.HeatTransfer icon Issues addresses the icon graphics labels Sep 18, 2024
@beutlich beutlich added this to the MSL4.2.0 milestone Sep 18, 2024
@beutlich beutlich changed the title Removed redundant text in celcius to kelvin icon Remove redundant text in celcius to kelvin icon Sep 18, 2024
Copy link
Contributor

@christiankral christiankral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks good

@casella casella changed the title Remove redundant text in celcius to kelvin icon Remove redundant text in celsius to kelvin icon Sep 26, 2024
Copy link
Contributor

@casella casella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@casella
Copy link
Contributor

casella commented Sep 26, 2024

@Esther-Devakirubai this is a minor fix with no consequences at the equation level, I guess we can safely back-port it to 4.1.0 while we wait for the completion of the regression testing.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icon Issues addresses the icon graphics L: Thermal.HeatTransfer Issue addresses Modelica.Thermal.HeatTransfer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants