Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snprintf.c #4498

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Update snprintf.c #4498

merged 1 commit into from
Jan 2, 2025

Conversation

beutlich
Copy link
Member

No description provided.

@beutlich beutlich added the L: C-Sources Issue addresses Modelica/Resources/C-Sources label Oct 31, 2024
@beutlich beutlich added this to the MSL4.2.0 milestone Oct 31, 2024
@casella
Copy link
Contributor

casella commented Nov 11, 2024

@beutlich I guess we can just take in this code by trusting the source https://github.com/weiss/c99-snprintf, right?

@beutlich
Copy link
Member Author

@beutlich I guess we can just take in this code by trusting the source https://github.com/weiss/c99-snprintf, right?

Yes, since already distributed via matio ≥ v1.2.7.

Copy link
Contributor

@casella casella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maltelenz
Copy link
Contributor

I don't feel qualified to review this, but can confirm it builds for me...

@maltelenz maltelenz removed their request for review November 14, 2024 09:49
@beutlich beutlich enabled auto-merge (squash) November 16, 2024 09:52
@beutlich beutlich requested review from HansOlsson and removed request for sjoelund and GallLeo December 28, 2024 10:57
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beutlich beutlich merged commit b60bc79 into modelica:master Jan 2, 2025
11 checks passed
@beutlich beutlich deleted the update-c99-snprint branch January 2, 2025 09:22
@beutlich beutlich self-assigned this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: C-Sources Issue addresses Modelica/Resources/C-Sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants