-
Notifications
You must be signed in to change notification settings - Fork 41
Explorer API collects feedback from agent applications #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @pan-x-c, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a robust mechanism for collecting feedback from agent applications interacting with the Explorer API. It establishes a session-based system where experiences generated during a session can be linked and later attributed with a reward, enabling more sophisticated reinforcement learning feedback loops. The changes span the API endpoints, the core service logic for managing experiences, and the client-side integration for agents. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a mechanism for collecting feedback from agent applications through new API endpoints. It adds session management to associate experiences with feedback. The overall implementation is sound, but I've identified a critical bug in an API call and a high-severity issue related to the lack of input validation, which could lead to server errors. My review includes suggestions to fix these issues.
|
/unittest-all |
Summary
Skipped
Tests
Github Test Reporter by CTRF 💚 |
|
/unittest-all |
|
/unittest-all |
Description
As the title says
Checklist
Please check the following items before code is ready to be reviewed.